Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-15 Thread Steven Rostedt
On Fri, 15 Jan 2021 13:53:19 +0100 Alexander Potapenko wrote: > > #define REPORT_TOOL_LIST \ > > EM(KFENCE, kfence) \ > > EMe(KASAN, kasan) > > Thanks, will be done in v2! > Note that checkpatch doesn't really like this declaration style, > claiming that "Macros with complex values should

Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-15 Thread Alexander Potapenko
On Thu, Jan 14, 2021 at 3:52 PM Steven Rostedt wrote: > > On Thu, 14 Jan 2021 08:49:57 +0100 > Alexander Potapenko wrote: > > > We'll need to explicitly list the enum values once again in > > __print_symbolic(), right? E.g.: > > > > enum debugging_tool { > > TOOL_KFENCE, > >

Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-14 Thread Steven Rostedt
On Thu, 14 Jan 2021 08:49:57 +0100 Alexander Potapenko wrote: > We'll need to explicitly list the enum values once again in > __print_symbolic(), right? E.g.: > > enum debugging_tool { > TOOL_KFENCE, > TOOL_KASAN, > ... > } > >

Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-14 Thread Marco Elver
On Thu, 14 Jan 2021 at 08:50, Alexander Potapenko wrote: > > On Wed, Jan 13, 2021 at 10:10 PM Steven Rostedt wrote: > > > > On Wed, 13 Jan 2021 10:16:54 +0100 > > Alexander Potapenko wrote: > > > > > +DECLARE_EVENT_CLASS(error_report_template, > > > + TP_PROTO(const char

Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-13 Thread Alexander Potapenko
On Wed, Jan 13, 2021 at 10:10 PM Steven Rostedt wrote: > > On Wed, 13 Jan 2021 10:16:54 +0100 > Alexander Potapenko wrote: > > > +DECLARE_EVENT_CLASS(error_report_template, > > + TP_PROTO(const char *error_detector, unsigned long id), > > Instead of having a random string, as

Re: [PATCH 1/4] tracing: add error_report trace points

2021-01-13 Thread Steven Rostedt
On Wed, 13 Jan 2021 10:16:54 +0100 Alexander Potapenko wrote: > +DECLARE_EVENT_CLASS(error_report_template, > + TP_PROTO(const char *error_detector, unsigned long id), Instead of having a random string, as this should be used by a small finite set of subsystems, why not make the

[PATCH 1/4] tracing: add error_report trace points

2021-01-13 Thread Alexander Potapenko
Introduce error_report_start and error_report_end tracepoints. Those can be used in debugging tools like KASAN, KFENCE, etc. to provide extensions to the error reporting mechanisms (e.g. allow tests hook into error reporting, ease error report collection from production kernels). Another benefit