Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

2015-05-18 Thread Dave Chinner
On Mon, May 18, 2015 at 08:06:13PM +0200, Fabian Frederick wrote: > > > > On 18 May 2015 at 19:19 Al Viro wrote: > > > > > > On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: > > >      * If the block order is wrong, swap the arguments. > > >      */ > > > -   if ((swap = xfs_dir

Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

2015-05-18 Thread Fabian Frederick
> On 18 May 2015 at 19:19 Al Viro wrote: > > > On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: > >      * If the block order is wrong, swap the arguments. > >      */ > > -   if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp))) { > > -           xfs_da_state_blk_t      *t

[PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

2015-05-18 Thread Fabian Frederick
Use kernel.h macro definition. Also remove assignment in if condition (checkpatch error) Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_dir2_node.c | 8 ++-- Signed-off-by: Fabian Frederick --- fs/xfs/libxfs/xfs_dir2_node.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions

Re: [PATCH 1/4 linux-next] xfs: use swap() in xfs_dir2_leafn_rebalance()

2015-05-18 Thread Al Viro
On Mon, May 18, 2015 at 07:13:48PM +0200, Fabian Frederick wrote: >* If the block order is wrong, swap the arguments. >*/ > - if ((swap = xfs_dir2_leafn_order(dp, blk1->bp, blk2->bp))) { > - xfs_da_state_blk_t *tmp; /* temp for block swap */ > + swap = xfs