Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-30 Thread SF Markus Elfring
>> @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, >> void *context) >> out: >> release_firmware(fw); >> complete_all(>nvs_loading_complete); >> + return; >> + >> +power_off: > > Name this "out_power_off" to match the other labels. Do you

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-30 Thread SF Markus Elfring
>> @@ -6551,6 +6549,11 @@ static void wlcore_nvs_cb(const struct firmware *fw, >> void *context) >> out: >> release_firmware(fw); >> complete_all(>nvs_loading_complete); >> + return; >> + >> +power_off: > > Name this "out_power_off" to match the other labels. Do you

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-30 Thread Julian Calaby
Hi Markus, On Mon, Oct 30, 2017 at 7:11 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 29 Oct 2017 18:38:04 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this

Re: [PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-30 Thread Julian Calaby
Hi Markus, On Mon, Oct 30, 2017 at 7:11 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 29 Oct 2017 18:38:04 +0100 > > Add a jump target so that a bit of exception handling can be better reused > at the end of this function. > > This issue was detected by using the Coccinelle

[PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 29 Oct 2017 18:38:04 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring

[PATCH 1/5] wlcore: Use common error handling code in wlcore_nvs_cb()

2017-10-29 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 29 Oct 2017 18:38:04 +0100 Add a jump target so that a bit of exception handling can be better reused at the end of this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/wireless/ti/wlcore/main.c