Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-29 Thread Mark Brown
On Mon, Nov 20, 2017 at 09:31:40PM +0530, arvindY wrote: > On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: > > On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: > > To ensure this doesn't get applied: platform_get_irq can return > > -EPROBE_DEFER and this must be handled

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-29 Thread Mark Brown
On Mon, Nov 20, 2017 at 09:31:40PM +0530, arvindY wrote: > On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: > > On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: > > To ensure this doesn't get applied: platform_get_irq can return > > -EPROBE_DEFER and this must be handled

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-20 Thread arvindY
Hi, On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-20 Thread arvindY
Hi, On Monday 20 November 2017 07:07 PM, Alexandre Belloni wrote: On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct.

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-20 Thread Alexandre Belloni
On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- >

Re: [alsa-devel] [PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-20 Thread Alexandre Belloni
On 19/11/2017 at 09:45:00 +0530, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2 : >

[PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : irq was unsigned. so changed it to signed.

[PATCH 1/5 v4] ASoC: ep93xx-ac97: Fix platform_get_irq's error checking

2017-11-18 Thread Arvind Yadav
The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : irq was unsigned. so changed it to signed. changes in v3 :