Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-30 Thread Lee Jones
On Wed, 25 Apr 2018, Daniel Vetter wrote: > The backlight power state handling is supremely confusing. We have: > - props.power, using FB_BLANK_* defines > - props.fb_blank, using the same, but deprecated int favour of > props.state > - props.state, using the BL_CORE_* defines > - and finally a

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-30 Thread Jani Nikula
On Wed, 25 Apr 2018, Daniel Vetter wrote: > The backlight power state handling is supremely confusing. We have: > - props.power, using FB_BLANK_* defines > - props.fb_blank, using the same, but deprecated int favour of > props.state > - props.state, using the BL_CORE_* defines > - and finally a

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-25 Thread Jingoo Han
On Wednesday, April 25, 2018 1:43 PM, Daniel Vetter wrote: > > The backlight power state handling is supremely confusing. We have: > - props.power, using FB_BLANK_* defines > - props.fb_blank, using the same, but deprecated int favour of > props.state > - props.state, using the BL_CORE_* defines

[PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-04-25 Thread Daniel Vetter
The backlight power state handling is supremely confusing. We have: - props.power, using FB_BLANK_* defines - props.fb_blank, using the same, but deprecated int favour of props.state - props.state, using the BL_CORE_* defines - and finally a bunch of backlight drivers treat brightness == 0 as o

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-01-18 Thread Lee Jones
On Wed, 17 Jan 2018, Daniel Thompson wrote: > On 17/01/18 14:01, Daniel Vetter wrote: > > The backlight power state handling is supremely confusing. We have: > > - props.power, using FB_BLANK_* defines > > - props.fb_blank, using the same, but deprecated int favour of > >props.state > > - prop

Re: [PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-01-17 Thread Daniel Thompson
On 17/01/18 14:01, Daniel Vetter wrote: The backlight power state handling is supremely confusing. We have: - props.power, using FB_BLANK_* defines - props.fb_blank, using the same, but deprecated int favour of props.state - props.state, using the BL_CORE_* defines - and finally a bunch of bac

[PATCH 1/6] backlight: Nuke unused backlight.props.state states

2018-01-17 Thread Daniel Vetter
The backlight power state handling is supremely confusing. We have: - props.power, using FB_BLANK_* defines - props.fb_blank, using the same, but deprecated int favour of props.state - props.state, using the BL_CORE_* defines - and finally a bunch of backlight drivers treat brightness == 0 as o