Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-19 Thread Steven Rostedt
On Wed, 19 Jun 2019 11:28:22 +0900 Masami Hiramatsu wrote: > > BTW, > > > > I pulled in patches 1-9 and I'm starting to test them now. > > Thanks! Should I send 10-21 patches in v2? Yes please. The tests have passed, and I will be pushing them to linux-next soon. But as I'm currently

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-18 Thread Masami Hiramatsu
On Tue, 18 Jun 2019 17:11:15 -0400 Steven Rostedt wrote: > On Tue, 18 Jun 2019 12:23:22 -0400 > Steven Rostedt wrote: > > > > Oops, good catch! > > > This part is related to caller (ftrace/perf) so should be more careful. > > > Usually, kprobe enablement should not fail. If one of them has > >

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-18 Thread Masami Hiramatsu
On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt wrote: > On Wed, 19 Jun 2019 01:14:09 +0900 > Masami Hiramatsu wrote: > > > On Mon, 17 Jun 2019 21:56:43 -0400 > > Steven Rostedt wrote: > > > > > > > +static nokprobe_inline struct trace_kprobe * > > > >

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-18 Thread Steven Rostedt
On Tue, 18 Jun 2019 12:23:22 -0400 Steven Rostedt wrote: > > Oops, good catch! > > This part is related to caller (ftrace/perf) so should be more careful. > > Usually, kprobe enablement should not fail. If one of them has > > gone (like a probe on unloaded module), it can be fail but that > >

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-18 Thread Steven Rostedt
On Wed, 19 Jun 2019 01:14:09 +0900 Masami Hiramatsu wrote: > On Mon, 17 Jun 2019 21:56:43 -0400 > Steven Rostedt wrote: > > > > +static nokprobe_inline struct trace_kprobe * > > > +trace_kprobe_primary_from_call(struct trace_event_call *call) > > > +{ > > > + struct trace_probe *tp =

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-18 Thread Masami Hiramatsu
On Mon, 17 Jun 2019 21:56:43 -0400 Steven Rostedt wrote: > On Sat, 1 Jun 2019 00:18:16 +0900 > Masami Hiramatsu wrote: > > > Split the trace_event related data from trace_probe data structure > > and introduce trace_probe_event data structure for its folder. > > This trace_probe_event data

Re: [PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-06-17 Thread Steven Rostedt
On Sat, 1 Jun 2019 00:18:16 +0900 Masami Hiramatsu wrote: > Split the trace_event related data from trace_probe data structure > and introduce trace_probe_event data structure for its folder. > This trace_probe_event data structure can have multiple trace_probe. > > Signed-off-by: Masami

[PATCH 10/21] tracing/probe: Split trace_event related data from trace_probe

2019-05-31 Thread Masami Hiramatsu
Split the trace_event related data from trace_probe data structure and introduce trace_probe_event data structure for its folder. This trace_probe_event data structure can have multiple trace_probe. Signed-off-by: Masami Hiramatsu --- kernel/trace/trace_kprobe.c | 99