Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 4:12 AM, Dan Carpenter wrote: > On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> > From: Todd Poynor >> > >> > Return right away instead of break out of while and then return. >> > >> > >

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 4:12 AM, Dan Carpenter wrote: > On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: >> On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> > From: Todd Poynor >> > >> > Return right away instead of break out of while and then return. >> > >> > >

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Return right away instead of break out of while and then return. >> > > You could remove the (retries == max_retries) condition since that's > always

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 3:13 AM, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: >> From: Todd Poynor >> >> Return right away instead of break out of while and then return. >> > > You could remove the (retries == max_retries) condition since that's > always

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Return right away instead of break out of while and then return. > > > Btw, I wasn't going to complain about this but since Greg is being

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Tue, Jul 17, 2018 at 01:13:29PM +0300, Dan Carpenter wrote: > On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: > > From: Todd Poynor > > > > Return right away instead of break out of while and then return. > > > Btw, I wasn't going to complain about this but since Greg is being

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return right away instead of break out of while and then return. > You could remove the (retries == max_retries) condition since that's always true now and pull that code in one tab. You could do it in one

Re: [PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

On Mon, Jul 16, 2018 at 07:09:06PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return right away instead of break out of while and then return. > You could remove the (retries == max_retries) condition since that's always true now and pull that code in one tab. You could do it in one

[PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

From: Todd Poynor Return right away instead of break out of while and then return. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 12/32] staging: gasket: gasket_wait_with_reschedule return when condition hit

From: Todd Poynor Return right away instead of break out of while and then return. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git