Re: [PATCH 14/14] sched,lockdep: Employ lock pinning

2015-06-05 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > > > Employ the new lockdep lock pinning annotation to ensure no > > > 'accidental' lock-breaks happen with rq->lock. > > > > btw., could we perhaps reorder this series a bit and f

Re: [PATCH 14/14] sched,lockdep: Employ lock pinning

2015-06-05 Thread Peter Zijlstra
On Fri, 2015-06-05 at 11:57 +0200, Ingo Molnar wrote: > * Peter Zijlstra wrote: > > > Employ the new lockdep lock pinning annotation to ensure no > > 'accidental' lock-breaks happen with rq->lock. > > btw., could we perhaps reorder this series a bit and first see that it > properly > detects t

Re: [PATCH 14/14] sched,lockdep: Employ lock pinning

2015-06-05 Thread Ingo Molnar
* Peter Zijlstra wrote: > Employ the new lockdep lock pinning annotation to ensure no > 'accidental' lock-breaks happen with rq->lock. btw., could we perhaps reorder this series a bit and first see that it properly detects the original locking bug, and then only fix the bug? To make sure the

[PATCH 14/14] sched,lockdep: Employ lock pinning

2015-06-05 Thread Peter Zijlstra
Employ the new lockdep lock pinning annotation to ensure no 'accidental' lock-breaks happen with rq->lock. Signed-off-by: Peter Zijlstra (Intel) --- kernel/sched/core.c | 42 +++--- kernel/sched/deadline.c |8 kernel/sched/fair.c | 11