On 31-07-15, 11:00, Joe Perches wrote:
> On Fri, 2015-07-31 at 16:36 +0530, Viresh Kumar wrote:
> > On 31-07-15, 03:28, Joe Perches wrote:
> > > If it's all fixed, then it's unlikely to be needed in checkpatch.
> >
> > I thought checkpatch is more about not committing new mistakes, rather than
>
On 31-07-15, 11:00, Joe Perches wrote:
On Fri, 2015-07-31 at 16:36 +0530, Viresh Kumar wrote:
On 31-07-15, 03:28, Joe Perches wrote:
If it's all fixed, then it's unlikely to be needed in checkpatch.
I thought checkpatch is more about not committing new mistakes, rather than
finding
On Fri, 2015-07-31 at 16:36 +0530, Viresh Kumar wrote:
> On 31-07-15, 03:28, Joe Perches wrote:
> > If it's all fixed, then it's unlikely to be needed in checkpatch.
>
> I thought checkpatch is more about not committing new mistakes, rather than
> finding them in old code.
True, but checkpatch
On 31-07-15, 03:28, Joe Perches wrote:
> If it's all fixed, then it's unlikely to be needed in checkpatch.
I thought checkpatch is more about not committing new mistakes, rather than
finding them in old code.
--
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
On Fri, 2015-07-31 at 15:04 +0530, Viresh Kumar wrote:
> On 31-07-15, 17:32, yalin wang wrote:
> >
> > > On Jul 31, 2015, at 16:56, Kirill A. Shutemov
> > > wrote:
> > >
> > > On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
> > >> IS_ERR(_OR_NULL) already contain an 'unlikely'
On 31-07-15, 17:32, yalin wang wrote:
>
> > On Jul 31, 2015, at 16:56, Kirill A. Shutemov wrote:
> >
> > On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
> >> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> >> is no need to do that again from its callers.
> On Jul 31, 2015, at 16:56, Kirill A. Shutemov wrote:
>
> On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
>> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
>> is no need to do that again from its callers. Drop it.
>>
>> Signed-off-by: Viresh Kumar
>
>
On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
> is no need to do that again from its callers. Drop it.
>
> Signed-off-by: Viresh Kumar
Acked-by: Kirill A. Shutemov
--
Kirill A. Shutemov
--
To
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
Signed-off-by: Viresh Kumar
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index
On Fri, 2015-07-31 at 16:36 +0530, Viresh Kumar wrote:
On 31-07-15, 03:28, Joe Perches wrote:
If it's all fixed, then it's unlikely to be needed in checkpatch.
I thought checkpatch is more about not committing new mistakes, rather than
finding them in old code.
True, but checkpatch is more
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
mm/huge_memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/huge_memory.c
On 31-07-15, 17:32, yalin wang wrote:
On Jul 31, 2015, at 16:56, Kirill A. Shutemov kir...@shutemov.name wrote:
On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its
On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Acked-by: Kirill A. Shutemov
On Jul 31, 2015, at 16:56, Kirill A. Shutemov kir...@shutemov.name wrote:
On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there
is no need to do that again from its callers. Drop it.
Signed-off-by: Viresh
On 31-07-15, 03:28, Joe Perches wrote:
If it's all fixed, then it's unlikely to be needed in checkpatch.
I thought checkpatch is more about not committing new mistakes, rather than
finding them in old code.
--
viresh
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
On Fri, 2015-07-31 at 15:04 +0530, Viresh Kumar wrote:
On 31-07-15, 17:32, yalin wang wrote:
On Jul 31, 2015, at 16:56, Kirill A. Shutemov kir...@shutemov.name
wrote:
On Fri, Jul 31, 2015 at 02:08:34PM +0530, Viresh Kumar wrote:
IS_ERR(_OR_NULL) already contain an 'unlikely'
16 matches
Mail list logo