Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-18 Thread Johannes Weiner
On Fri, Jul 15, 2016 at 03:35:54PM -0700, Andrew Morton wrote: > Well I dunno. We can leave the series as-is for now and we can merge > the rename-it-back patch sometime during the next -rc cycle if we find > that people are running around in confusion and tumbling out of high > windows. Sounds g

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-15 Thread Andrew Morton
On Fri, 15 Jul 2016 11:46:05 +0100 Mel Gorman wrote: > On Wed, Jul 13, 2016 at 02:13:43PM -0700, Andrew Morton wrote: > > On Wed, 13 Jul 2016 14:37:01 +0100 Mel Gorman > > wrote: > > > > > > I don't care strongly enough to cause a respin of half the series, and > > > > it's not your problem t

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-15 Thread Mel Gorman
On Wed, Jul 13, 2016 at 02:13:43PM -0700, Andrew Morton wrote: > On Wed, 13 Jul 2016 14:37:01 +0100 Mel Gorman > wrote: > > > > I don't care strongly enough to cause a respin of half the series, and > > > it's not your problem that I waited until the last revision went into > > > mmots to review

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-13 Thread Minchan Kim
On Wed, Jul 13, 2016 at 02:37:01PM +0100, Mel Gorman wrote: > On Wed, Jul 13, 2016 at 09:04:15AM -0400, Johannes Weiner wrote: > > > Obviously I found the new names clearer but I was thinking a lot at the > > > time about mapped vs unmapped due to looking closely at both reclaim and > > > [f|m]advi

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-13 Thread Andrew Morton
On Wed, 13 Jul 2016 14:37:01 +0100 Mel Gorman wrote: > > I don't care strongly enough to cause a respin of half the series, and > > it's not your problem that I waited until the last revision went into > > mmots to review and comment. But if you agreed to a revert, would you > > consider tacking

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-13 Thread Mel Gorman
On Wed, Jul 13, 2016 at 09:04:15AM -0400, Johannes Weiner wrote: > > Obviously I found the new names clearer but I was thinking a lot at the > > time about mapped vs unmapped due to looking closely at both reclaim and > > [f|m]advise functions at the time. I found it mildly irksome to switch > > be

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-13 Thread Johannes Weiner
On Wed, Jul 13, 2016 at 09:55:16AM +0100, Mel Gorman wrote: > On Tue, Jul 12, 2016 at 10:58:01AM -0400, Johannes Weiner wrote: > > On Fri, Jul 08, 2016 at 10:34:54AM +0100, Mel Gorman wrote: > > > NR_FILE_PAGES is the number offile pages. > > > NR_FILE_MAPPED is the number of mapped file p

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-13 Thread Mel Gorman
On Tue, Jul 12, 2016 at 10:58:01AM -0400, Johannes Weiner wrote: > On Fri, Jul 08, 2016 at 10:34:54AM +0100, Mel Gorman wrote: > > NR_FILE_PAGES is the number offile pages. > > NR_FILE_MAPPED is the number of mapped file pages. > > NR_ANON_PAGES is the number of mapped anon pages. > > >

Re: [PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-12 Thread Johannes Weiner
On Fri, Jul 08, 2016 at 10:34:54AM +0100, Mel Gorman wrote: > NR_FILE_PAGES is the number offile pages. > NR_FILE_MAPPED is the number of mapped file pages. > NR_ANON_PAGES is the number of mapped anon pages. > > This is unhelpful naming as it's easy to confuse NR_FILE_MAPPED and > NR_AN

[PATCH 18/34] mm: rename NR_ANON_PAGES to NR_ANON_MAPPED

2016-07-08 Thread Mel Gorman
NR_FILE_PAGES is the number offile pages. NR_FILE_MAPPED is the number of mapped file pages. NR_ANON_PAGES is the number of mapped anon pages. This is unhelpful naming as it's easy to confuse NR_FILE_MAPPED and NR_ANON_PAGES for mapped pages. This patch renames NR_ANON_PAGES so we have