Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-28 Thread Paul Bolle
[Yes, this patch is superseded by your series starting at https://lkml.org/lkml/2015/5/14/447 . But I wanted to jot this down somewhere.] On Tue, 2015-05-12 at 00:15 +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote: > > On Mon, May 11, 2015 at 11:50:21PM +0200,

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-28 Thread Paul Bolle
[Yes, this patch is superseded by your series starting at https://lkml.org/lkml/2015/5/14/447 . But I wanted to jot this down somewhere.] On Tue, 2015-05-12 at 00:15 +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 11:50:21PM +0200, Paul

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:36:49AM +0200, Luis R. Rodriguez wrote: > On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: > > init/Kconfig| 232 > > +--- > > init/Kconfig.expert | 231 > >

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:01:27AM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: > > On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: > > > Is squashing those two lines worth a new kconfig mechanism? > > > > In my opinion, yes. If you use the

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Luis R. Rodriguez
On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: > init/Kconfig| 232 > +--- > init/Kconfig.expert | 231 +++ > 2 files changed, 232 insertions(+), 231 deletions(-) > create

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote: > On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: > > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > > +config KALLSYMS_ALL > > > + bool "Include all symbols in kallsyms" > > > > (For some reason this entry doesn't

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > --- /dev/null > > +++ b/init/Kconfig.expert > > @@ -0,0 +1,231 @@ > > +menuconfig EXPERT > > + bool "Configure standard kernel features (expert users)" > > + # Unhide debug

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: > On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: > > Is squashing those two lines worth a new kconfig mechanism? > > In my opinion, yes. If you use the implicit (and error-prone) > menuconfig submenuing, you get a single entry

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > --- /dev/null > +++ b/init/Kconfig.expert > @@ -0,0 +1,231 @@ > +menuconfig EXPERT > + bool "Configure standard kernel features (expert users)" > + # Unhide debug options, to make the on-by-default options visible > + select

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: > > However, that would produce *two* entries under the "General setup" > > menu: a yes/no entry "Configure standard kernel features (expert users)" > > with no submenu, and a

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: > However, that would produce *two* entries under the "General setup" > menu: a yes/no entry "Configure standard kernel features (expert users)" > with no submenu, and a "Some separate menu prompt here" entry with a > submenu but no '[ ]' for

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote: > On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > > I'd also like to factor the "if EXPERT" off of all the prompts and into a > > single scoped item wrapped around all of them, but kconfig doesn't have any > > way > > to do

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: > I'd also like to factor the "if EXPERT" off of all the prompts and into a > single scoped item wrapped around all of them, but kconfig doesn't have any > way > to do that. "menuconfig" is just a hint, with no matching "endmenu" and no >

[PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
The expert menu frequently gets broken by a config item in the middle that leaves off the "if EXPERT" from its prompt. This results in the remainder of the menu spilling out into the parent "General setup" menu. Move the entire expert menu into a separate Kconfig file, init/Kconfig.expert, to

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: --- /dev/null +++ b/init/Kconfig.expert @@ -0,0 +1,231 @@ +menuconfig EXPERT + bool Configure standard kernel features (expert users) + # Unhide debug options, to make the on-by-default options visible + select DEBUG_KERNEL

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 15:04 -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: +config KALLSYMS_ALL + bool Include all symbols in kallsyms (For some reason this entry doesn't have if EXPERT

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: However, that would produce *two* entries under the General setup menu: a yes/no entry Configure standard kernel features (expert users) with no submenu, and a Some separate menu prompt here entry with a submenu but no '[ ]' for a yes/no

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 14:18 -0700, Josh Triplett wrote: However, that would produce *two* entries under the General setup menu: a yes/no entry Configure standard kernel features (expert users) with no submenu, and a Some separate

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: Is squashing those two lines worth a new kconfig mechanism? In my opinion, yes. If you use the implicit (and error-prone) menuconfig submenuing, you get a single entry with

[PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
The expert menu frequently gets broken by a config item in the middle that leaves off the if EXPERT from its prompt. This results in the remainder of the menu spilling out into the parent General setup menu. Move the entire expert menu into a separate Kconfig file, init/Kconfig.expert, to make

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Paul Bolle
On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: I'd also like to factor the if EXPERT off of all the prompts and into a single scoped item wrapped around all of them, but kconfig doesn't have any way to do that. menuconfig is just a hint, with no matching endmenu and no implicit

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:01:22PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: I'd also like to factor the if EXPERT off of all the prompts and into a single scoped item wrapped around all of them, but kconfig doesn't have any way to do that.

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Mon, May 11, 2015 at 11:50:21PM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 13:23 -0700, Josh Triplett wrote: --- /dev/null +++ b/init/Kconfig.expert @@ -0,0 +1,231 @@ +menuconfig EXPERT + bool Configure standard kernel features (expert users) + # Unhide debug options, to

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:36:49AM +0200, Luis R. Rodriguez wrote: On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: init/Kconfig| 232 +--- init/Kconfig.expert | 231

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Josh Triplett
On Tue, May 12, 2015 at 12:01:27AM +0200, Paul Bolle wrote: On Mon, 2015-05-11 at 14:47 -0700, Josh Triplett wrote: On Mon, May 11, 2015 at 11:32:28PM +0200, Paul Bolle wrote: Is squashing those two lines worth a new kconfig mechanism? In my opinion, yes. If you use the implicit (and

Re: [PATCH 2/1] init/Kconfig: Split expert menu into a separate file, init/Kconfig.expert

2015-05-11 Thread Luis R. Rodriguez
On Mon, May 11, 2015 at 01:23:02PM -0700, Josh Triplett wrote: init/Kconfig| 232 +--- init/Kconfig.expert | 231 +++ 2 files changed, 232 insertions(+), 231 deletions(-) create mode