Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Vivek Goyal
On Thu, Aug 16, 2018 at 09:11:06AM +0800, Dave Young wrote: > On 08/16/18 at 12:07am, Yannik Sembritzki wrote: > > Signed-off-by: Yannik Sembritzki > > --- > >  arch/x86/kernel/kexec-bzimage64.c   | 2 +- > >  certs/system_keyring.c  | 3 ++- > >  

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Vivek Goyal
On Thu, Aug 16, 2018 at 09:11:06AM +0800, Dave Young wrote: > On 08/16/18 at 12:07am, Yannik Sembritzki wrote: > > Signed-off-by: Yannik Sembritzki > > --- > >  arch/x86/kernel/kexec-bzimage64.c   | 2 +- > >  certs/system_keyring.c  | 3 ++- > >  

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Greg Kroah-Hartman
On Thu, Aug 16, 2018 at 04:02:59PM +0800, Dave Young wrote: > On 08/16/18 at 09:43am, Yannik Sembritzki wrote: > > On 16.08.2018 03:11, Dave Young wrote: > > > Instead of fix your 1st patch in 2nd patch, I would suggest to > > > switch the patch order. In 1st patch change the common code to use >

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Greg Kroah-Hartman
On Thu, Aug 16, 2018 at 04:02:59PM +0800, Dave Young wrote: > On 08/16/18 at 09:43am, Yannik Sembritzki wrote: > > On 16.08.2018 03:11, Dave Young wrote: > > > Instead of fix your 1st patch in 2nd patch, I would suggest to > > > switch the patch order. In 1st patch change the common code to use >

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Dave Young
On 08/16/18 at 09:43am, Yannik Sembritzki wrote: > On 16.08.2018 03:11, Dave Young wrote: > > Instead of fix your 1st patch in 2nd patch, I would suggest to > > switch the patch order. In 1st patch change the common code to use > > the new macro and in 2nd patch you can directly fix the kexec

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Dave Young
On 08/16/18 at 09:43am, Yannik Sembritzki wrote: > On 16.08.2018 03:11, Dave Young wrote: > > Instead of fix your 1st patch in 2nd patch, I would suggest to > > switch the patch order. In 1st patch change the common code to use > > the new macro and in 2nd patch you can directly fix the kexec

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Yannik Sembritzki
On 16.08.2018 03:11, Dave Young wrote: > Instead of fix your 1st patch in 2nd patch, I would suggest to > switch the patch order. In 1st patch change the common code to use > the new macro and in 2nd patch you can directly fix the kexec code > with TRUST_SECONDARY_KEYRING. My reasoning for doing

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-16 Thread Yannik Sembritzki
On 16.08.2018 03:11, Dave Young wrote: > Instead of fix your 1st patch in 2nd patch, I would suggest to > switch the patch order. In 1st patch change the common code to use > the new macro and in 2nd patch you can directly fix the kexec code > with TRUST_SECONDARY_KEYRING. My reasoning for doing

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Dave Young
On 08/16/18 at 12:07am, Yannik Sembritzki wrote: > Signed-off-by: Yannik Sembritzki > --- >  arch/x86/kernel/kexec-bzimage64.c   | 2 +- >  certs/system_keyring.c  | 3 ++- >  crypto/asymmetric_keys/pkcs7_key_type.c | 2 +- >  include/linux/verification.h    | 3 +++ >  4

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Dave Young
On 08/16/18 at 12:07am, Yannik Sembritzki wrote: > Signed-off-by: Yannik Sembritzki > --- >  arch/x86/kernel/kexec-bzimage64.c   | 2 +- >  certs/system_keyring.c  | 3 ++- >  crypto/asymmetric_keys/pkcs7_key_type.c | 2 +- >  include/linux/verification.h    | 3 +++ >  4

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Yannik Sembritzki
Signed-off-by: Yannik Sembritzki ---  arch/x86/kernel/kexec-bzimage64.c   | 2 +-  certs/system_keyring.c  | 3 ++-  crypto/asymmetric_keys/pkcs7_key_type.c | 2 +-  include/linux/verification.h    | 3 +++  4 files changed, 7 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define

2018-08-15 Thread Yannik Sembritzki
Signed-off-by: Yannik Sembritzki ---  arch/x86/kernel/kexec-bzimage64.c   | 2 +-  certs/system_keyring.c  | 3 ++-  crypto/asymmetric_keys/pkcs7_key_type.c | 2 +-  include/linux/verification.h    | 3 +++  4 files changed, 7 insertions(+), 3 deletions(-) diff --git