Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-11 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: + +#ifdef CONFIG_MPC834x_ITX Erm, isn't this stuff misplaced? Is this really SoC device? I remember seeng this in the arch/ppc/ platform code before (in the internal tree)... The point is to declare methods bsp, as mmio access may effectively vary (having

Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-11 Thread Vitaly Bordug
On Sat, 07 Jul 2007 20:46:46 +0400 Sergei Shtylyov wrote: > > + > > +#ifdef CONFIG_MPC834x_ITX > > Erm, isn't this stuff misplaced? Is this really SoC device? I > remember seeng this in the arch/ppc/ platform code before (in the > internal tree)... The point is to declare methods bsp, as m

Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-08 Thread Segher Boessenkool
+ [EMAIL PROTECTED] { + #interrupt-cells = <2>; Hm, why define that prop for a node with no children? + interrupts = <17 8>; + interrupt-map = <0 0 0 1 700 17 8>; + interrupt-map-mask = <0

Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-07 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: This updates relevant platform code (freescale mpc8349itx target) to make the CompactFlash work in TrueIDE mode. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> It would have been good if you tried to actual

Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-07 Thread Arnd Bergmann
On Saturday 07 July 2007, Olof Johansson wrote: > On Sat, Jul 07, 2007 at 01:49:00PM +0400, Vitaly Bordug wrote: > > > > This updates relevant platform code > > (freescale mpc8349itx target) to make the CompactFlash > > work in TrueIDE mode. > > Shouldn't you be writing a PCMCIA driver instead fo

Re: [PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-07 Thread Olof Johansson
On Sat, Jul 07, 2007 at 01:49:00PM +0400, Vitaly Bordug wrote: > > This updates relevant platform code > (freescale mpc8349itx target) to make the CompactFlash > work in TrueIDE mode. Shouldn't you be writing a PCMCIA driver instead for the CF, so it handles other devices as well? Then you get st

[PATCH 2/2] [POWERPC] mmio ide support for mpc8349-itx target

2007-07-07 Thread Vitaly Bordug
This updates relevant platform code (freescale mpc8349itx target) to make the CompactFlash work in TrueIDE mode. Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> Signed-off-by: Vitaly Bordug <[EMAIL PROTECTED]> --- arch/powerpc/boot/dts/mpc8349emitx.dts | 17 + arch/powerpc/sysdev/fsl_