Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2019-02-19 Thread Oleg Nesterov
On 02/19, Guenter Roeck wrote: > > On Tue, Feb 19, 2019 at 01:37:57PM +0100, Oleg Nesterov wrote: > > > > looks unrelated... > > > > Indeed... > > The underlying problem is in the error handling code of ace_setup(), > which calls put_disk() followed by blk_cleanup_queue(). put_disk() > calls disk_r

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2019-02-19 Thread Guenter Roeck
On Tue, Feb 19, 2019 at 01:37:57PM +0100, Oleg Nesterov wrote: > On 02/18, Guenter Roeck wrote: > > > > Unfortunately, this patch causes one of my qemu emulations to crash. > > The crash is not always seen, but at least with every other boot attempt. > > Hmm. I can't imagine how this change can ca

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2019-02-19 Thread Oleg Nesterov
On 02/18, Guenter Roeck wrote: > > Unfortunately, this patch causes one of my qemu emulations to crash. > The crash is not always seen, but at least with every other boot attempt. Hmm. I can't imagine how this change can cause the null-ptr-deref in blk_mq_run_hw_queue(). > Reverting the patch fix

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2019-02-18 Thread Guenter Roeck
Hi, On Mon, Nov 12, 2018 at 05:09:56PM +0100, Oleg Nesterov wrote: > Large enterprise clients often times run applications out of networked > file systems where the IT mandated layout of project volumes can end up > leading to paths that are longer than 128 characters. Bumping this up to > the nex

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-22 Thread Oleg Nesterov
On 11/16, Alan Cox wrote: > > On Mon, 12 Nov 2018 17:09:56 +0100 > Oleg Nesterov wrote: > > > Large enterprise clients often times run applications out of networked > > file systems where the IT mandated layout of project volumes can end up > > leading to paths that are longer than 128 characters.

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-16 Thread Alan Cox
On Mon, 12 Nov 2018 17:09:56 +0100 Oleg Nesterov wrote: > Large enterprise clients often times run applications out of networked > file systems where the IT mandated layout of project volumes can end up > leading to paths that are longer than 128 characters. Bumping this up to > the next order of

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-14 Thread Michal Hocko
On Wed 14-11-18 16:54:14, Oleg Nesterov wrote: > On 11/13, Andrew Morton wrote: > > > > On Tue, 13 Nov 2018 17:55:58 +0100 Oleg Nesterov wrote: > > > > > > However it would be basically cost-free to increase > > > > BINPRM_BUF_SIZE up to the point where sizeof(struct linux_binprm) == > > > > PAGE_

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-14 Thread Oleg Nesterov
On 11/13, Andrew Morton wrote: > > On Tue, 13 Nov 2018 17:55:58 +0100 Oleg Nesterov wrote: > > > > However it would be basically cost-free to increase > > > BINPRM_BUF_SIZE up to the point where sizeof(struct linux_binprm) == > > > PAGE_SIZE? > > > > I don't think we should take sizeof(struct linu

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-13 Thread Andrew Morton
On Tue, 13 Nov 2018 17:55:58 +0100 Oleg Nesterov wrote: > > However it would be basically cost-free to increase > > BINPRM_BUF_SIZE up to the point where sizeof(struct linux_binprm) == > > PAGE_SIZE? > > I don't think we should take sizeof(struct linux_binprm) into account, the > new members can

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-13 Thread Oleg Nesterov
On 11/12, Andrew Morton wrote: > On Mon, 12 Nov 2018 17:09:56 +0100 Oleg Nesterov wrote: > > > /* sizeof(linux_binprm->buf) */ > > -#define BINPRM_BUF_SIZE 128 > > +#define BINPRM_BUF_SIZE 256 > > > > #endif /* _UAPI_LINUX_BINFMTS_H */ > > It does seem a rather silly restriction, and it's tempt

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-13 Thread Michal Hocko
On Mon 12-11-18 17:09:56, Oleg Nesterov wrote: > Large enterprise clients often times run applications out of networked > file systems where the IT mandated layout of project volumes can end up > leading to paths that are longer than 128 characters. Bumping this up to > the next order of two solves

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-12 Thread Kees Cook
On Mon, Nov 12, 2018 at 5:52 PM, Andrew Morton wrote: > On Mon, 12 Nov 2018 17:09:56 +0100 Oleg Nesterov wrote: > >> Large enterprise clients often times run applications out of networked >> file systems where the IT mandated layout of project volumes can end up >> leading to paths that are longe

Re: [PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-12 Thread Andrew Morton
On Mon, 12 Nov 2018 17:09:56 +0100 Oleg Nesterov wrote: > Large enterprise clients often times run applications out of networked > file systems where the IT mandated layout of project volumes can end up > leading to paths that are longer than 128 characters. Bumping this up to > the next order of

[PATCH 2/2] exec: increase BINPRM_BUF_SIZE to 256

2018-11-12 Thread Oleg Nesterov
Large enterprise clients often times run applications out of networked file systems where the IT mandated layout of project volumes can end up leading to paths that are longer than 128 characters. Bumping this up to the next order of two solves this problem in all but the most egregious case while