Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > On 25/11/2015 13:12, Måns Rullgård wrote: > >> Mason writes: >> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); >>> >>> In my local branch, I wrote: >>> >>> #define IRQ_CTL_LO 0 >>> >>>

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 25/11/2015 13:12, Måns Rullgård wrote: > Mason writes: > >>> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >>> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); >> >> In my local branch, I wrote: >> >> #define IRQ_CTL_LO 0 >> >> status_lo =

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 25/11/2015 13:12, Måns Rullgård wrote: > Mason writes: > >>> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >>> + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); >> >> In my local branch, I wrote: >> >> #define IRQ_CTL_LO 0 >> >> status_lo =

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > On 25/11/2015 13:12, Måns Rullgård wrote: > >> Mason writes: >> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); >>> >>> In my local branch, I wrote: >>> >>> #define

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: >> +status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >> +status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > In my local branch, I wrote: > > #define IRQ_CTL_LO0 > > status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); >

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > [ Trimming CC list ] > > On 19/11/2015 19:33, Mans Rullgard wrote: > >> +config TANGOX_IRQ > > Could you drop the X? Sure, if that's what people prefer. > (And perhaps change IRQ to IRQCHIP? What's the current trend?) Most of the existing entries say just IRQ or something

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); > + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); In my local branch, I wrote: #define IRQ_CTL_LO 0 status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); status_hi =

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

[ Trimming CC list ] On 19/11/2015 19:33, Mans Rullgard wrote: > +config TANGOX_IRQ Could you drop the X? (And perhaps change IRQ to IRQCHIP? What's the current trend?) > + bool > + select IRQ_DOMAIN > + select GENERIC_IRQ_CHIP Could you sort alphabetically, like the mach Kconfig?

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

[ Trimming CC list ] On 19/11/2015 19:33, Mans Rullgard wrote: > +config TANGOX_IRQ Could you drop the X? (And perhaps change IRQ to IRQCHIP? What's the current trend?) > + bool > + select IRQ_DOMAIN > + select GENERIC_IRQ_CHIP Could you sort alphabetically, like the mach Kconfig?

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: >> +status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); >> +status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); > > In my local branch, I wrote: > > #define IRQ_CTL_LO0 > > status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO +

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > [ Trimming CC list ] > > On 19/11/2015 19:33, Mans Rullgard wrote: > >> +config TANGOX_IRQ > > Could you drop the X? Sure, if that's what people prefer. > (And perhaps change IRQ to IRQCHIP? What's the current trend?) Most of the existing entries say just

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

> + status_lo = intc_readl(chip, chip->ctl + IRQ_STATUS); > + status_hi = intc_readl(chip, chip->ctl + IRQ_CTL_HI + IRQ_STATUS); In my local branch, I wrote: #define IRQ_CTL_LO 0 status_lo = intc_readl(chip, chip->ctl + IRQ_CTL_LO + IRQ_STATUS); status_hi =

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > On 19/11/2015 19:33, Mans Rullgard wrote: > >> This adds support for the secondary interrupt controller used in Sigma >> Designs SMP86xx and SMP87xx chips. >> >> Signed-off-by: Mans Rullgard >> --- >> drivers/irqchip/Kconfig | 5 + >> drivers/irqchip/Makefile | 1

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 19/11/2015 19:33, Mans Rullgard wrote: > This adds support for the secondary interrupt controller used in Sigma > Designs SMP86xx and SMP87xx chips. > > Signed-off-by: Mans Rullgard > --- > drivers/irqchip/Kconfig | 5 + > drivers/irqchip/Makefile | 1 + >

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Marc Zyngier writes: >> +static void tangox_dispatch_irqs(struct irq_domain *dom, unsigned int >> status, >> + int base) >> +{ >> +unsigned int hwirq; >> +unsigned int virq; >> + >> +while (status) { >> +hwirq = __ffs(status); >> +

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 19/11/15 18:33, Mans Rullgard wrote: > This adds support for the secondary interrupt controller used in Sigma > Designs SMP86xx and SMP87xx chips. > > Signed-off-by: Mans Rullgard > --- > drivers/irqchip/Kconfig | 5 + > drivers/irqchip/Makefile | 1 + >

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Marc Zyngier writes: >> +static void tangox_dispatch_irqs(struct irq_domain *dom, unsigned int >> status, >> + int base) >> +{ >> +unsigned int hwirq; >> +unsigned int virq; >> + >> +while (status) { >> +hwirq =

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

Mason writes: > On 19/11/2015 19:33, Mans Rullgard wrote: > >> This adds support for the secondary interrupt controller used in Sigma >> Designs SMP86xx and SMP87xx chips. >> >> Signed-off-by: Mans Rullgard >> --- >> drivers/irqchip/Kconfig | 5 + >>

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 19/11/15 18:33, Mans Rullgard wrote: > This adds support for the secondary interrupt controller used in Sigma > Designs SMP86xx and SMP87xx chips. > > Signed-off-by: Mans Rullgard > --- > drivers/irqchip/Kconfig | 5 + > drivers/irqchip/Makefile | 1 + >

Re: [PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

On 19/11/2015 19:33, Mans Rullgard wrote: > This adds support for the secondary interrupt controller used in Sigma > Designs SMP86xx and SMP87xx chips. > > Signed-off-by: Mans Rullgard > --- > drivers/irqchip/Kconfig | 5 + > drivers/irqchip/Makefile | 1 + >

[PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

This adds support for the secondary interrupt controller used in Sigma Designs SMP86xx and SMP87xx chips. Signed-off-by: Mans Rullgard --- drivers/irqchip/Kconfig | 5 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-tangox.c | 232 +++

[PATCH 2/2] irqchip: add support for Sigma Designs SMP86xx interrupt controller

This adds support for the secondary interrupt controller used in Sigma Designs SMP86xx and SMP87xx chips. Signed-off-by: Mans Rullgard --- drivers/irqchip/Kconfig | 5 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-tangox.c | 232