Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread David Cohen
On 10/23/2013 11:23 AM, Felipe Balbi wrote: Hi again, On Wed, Oct 23, 2013 at 01:21:43PM -0500, Felipe Balbi wrote: On Wed, Oct 23, 2013 at 11:10:48AM -0700, David Cohen wrote: My idea is always use threaded irq and passing flags into request. Like as: unsigned long flags = res->flags & IORESO

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread Felipe Balbi
Hi, On Wed, Oct 23, 2013 at 11:33:45AM -0700, David Cohen wrote: > On 10/23/2013 11:21 AM, Felipe Balbi wrote: > >Hi, > > > >On Wed, Oct 23, 2013 at 11:10:48AM -0700, David Cohen wrote: > >>>My idea is always use threaded irq and passing flags into request. > >>>Like as: > >>>unsigned long flags =

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread David Cohen
On 10/23/2013 11:21 AM, Felipe Balbi wrote: Hi, On Wed, Oct 23, 2013 at 11:10:48AM -0700, David Cohen wrote: My idea is always use threaded irq and passing flags into request. Like as: unsigned long flags = res->flags & IORESOURCE_BITS; ... request_threaded_irq(max->irq, serial_m3110_irq, IRQF_

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread Felipe Balbi
Hi again, On Wed, Oct 23, 2013 at 01:21:43PM -0500, Felipe Balbi wrote: > On Wed, Oct 23, 2013 at 11:10:48AM -0700, David Cohen wrote: > > >My idea is always use threaded irq and passing flags into request. > > >Like as: > > >unsigned long flags = res->flags & IORESOURCE_BITS; > > >... > > >reques

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread Felipe Balbi
Hi, On Wed, Oct 23, 2013 at 11:10:48AM -0700, David Cohen wrote: > >My idea is always use threaded irq and passing flags into request. > >Like as: > >unsigned long flags = res->flags & IORESOURCE_BITS; > >... > >request_threaded_irq(max->irq, serial_m3110_irq, IRQF_ONESHOT | flags, > >"max3110",

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-23 Thread David Cohen
On 10/22/2013 11:27 PM, Alexander Shiyan wrote: On 10/22/2013 01:30 PM, David Cohen wrote: On 10/22/2013 12:46 PM, Alexander Shiyan wrote: The change in the max3110 driver makes the IRQ handling threaded, now the handler is called only once per received character. Without that change, we had ma

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-22 Thread Alexander Shiyan
> On 10/22/2013 01:30 PM, David Cohen wrote: > > On 10/22/2013 12:46 PM, Alexander Shiyan wrote: > >>> The change in the max3110 driver makes the IRQ handling threaded, now > >>> the handler is called only once per received character. Without that > >>> change, we had many (more than 100) interrupt

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-22 Thread David Cohen
On 10/22/2013 01:30 PM, David Cohen wrote: On 10/22/2013 12:46 PM, Alexander Shiyan wrote: The change in the max3110 driver makes the IRQ handling threaded, now the handler is called only once per received character. Without that change, we had many (more than 100) interrupts per one received ch

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-22 Thread David Cohen
On 10/22/2013 12:46 PM, Alexander Shiyan wrote: The change in the max3110 driver makes the IRQ handling threaded, now the handler is called only once per received character. Without that change, we had many (more than 100) interrupts per one received character. Unfortunately, SFI interface does

Re: [PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-22 Thread Alexander Shiyan
> The change in the max3110 driver makes the IRQ handling threaded, now > the handler is called only once per received character. Without that > change, we had many (more than 100) interrupts per one received > character. > > Unfortunately, SFI interface does not support IRQ polarity and > trigger

[PATCH 2/2] mrst_max3110: fix SPI UART interrupt parameters

2013-10-22 Thread David Cohen
From: Ivan Gorinov The change in the max3110 driver makes the IRQ handling threaded, now the handler is called only once per received character. Without that change, we had many (more than 100) interrupts per one received character. Unfortunately, SFI interface does not support IRQ polarity and