Re: [PATCH 2/2] regulator: rk808: Fix missing of_node_put

2014-09-12 Thread Doug Anderson
Axel, On Thu, Sep 11, 2014 at 3:22 AM, Axel Lin wrote: > 1. Pass >dev rather than >dev to of_regulator_match, the *dev >argument is used for devres to ensure devm_of_regulator_put_matches() will >be called when unload the module. > > 2. of_get_child_by_name() returns a node pointer with

Re: [PATCH 2/2] regulator: rk808: Fix missing of_node_put

2014-09-12 Thread Doug Anderson
Axel, On Thu, Sep 11, 2014 at 3:22 AM, Axel Lin axel@ingics.com wrote: 1. Pass pdev-dev rather than client-dev to of_regulator_match, the *dev argument is used for devres to ensure devm_of_regulator_put_matches() will be called when unload the module. 2. of_get_child_by_name()

[PATCH 2/2] regulator: rk808: Fix missing of_node_put

2014-09-11 Thread Axel Lin
1. Pass >dev rather than >dev to of_regulator_match, the *dev argument is used for devres to ensure devm_of_regulator_put_matches() will be called when unload the module. 2. of_get_child_by_name() returns a node pointer with refcount incremented. Thus add missing of_node_put(reg_np).

[PATCH 2/2] regulator: rk808: Fix missing of_node_put

2014-09-11 Thread Axel Lin
1. Pass pdev-dev rather than client-dev to of_regulator_match, the *dev argument is used for devres to ensure devm_of_regulator_put_matches() will be called when unload the module. 2. of_get_child_by_name() returns a node pointer with refcount incremented. Thus add missing