Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-06 Thread Patrick Bellasi
Hi Vincent, On 06-Jun 10:26, Vincent Guittot wrote: [...] > For the above 2 tasks of the example example we have the pattern > > Task 1 > state SSESSESS > util_avgDD DD DD > > Task 2 > state SSESSESS >

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-06 Thread Patrick Bellasi
Hi Vincent, On 06-Jun 10:26, Vincent Guittot wrote: [...] > For the above 2 tasks of the example example we have the pattern > > Task 1 > state SSESSESS > util_avgDD DD DD > > Task 2 > state SSESSESS >

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-06 Thread Vincent Guittot
Le Tuesday 05 Jun 2018 à 16:11:29 (+0100), Patrick Bellasi a écrit : > Hi Vincent, > > On 05-Jun 08:57, Vincent Guittot wrote: > > On 4 June 2018 at 18:06, Patrick Bellasi wrote: > > [...] > > > > Let's improve the estimated utilization by adding a new "sort-of" PELT > > > signal, explicitly

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-06 Thread Vincent Guittot
Le Tuesday 05 Jun 2018 à 16:11:29 (+0100), Patrick Bellasi a écrit : > Hi Vincent, > > On 05-Jun 08:57, Vincent Guittot wrote: > > On 4 June 2018 at 18:06, Patrick Bellasi wrote: > > [...] > > > > Let's improve the estimated utilization by adding a new "sort-of" PELT > > > signal, explicitly

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Saravana Kannan
On 06/05/2018 01:46 PM, Joel Fernandes wrote: On Tue, Jun 05, 2018 at 05:54:31PM +0100, Patrick Bellasi wrote: On 05-Jun 17:31, Juri Lelli wrote: On 05/06/18 16:11, Patrick Bellasi wrote: [...] If I run an experiment with your example above, while using the performance governor to rule out

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Saravana Kannan
On 06/05/2018 01:46 PM, Joel Fernandes wrote: On Tue, Jun 05, 2018 at 05:54:31PM +0100, Patrick Bellasi wrote: On 05-Jun 17:31, Juri Lelli wrote: On 05/06/18 16:11, Patrick Bellasi wrote: [...] If I run an experiment with your example above, while using the performance governor to rule out

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 05:54:31PM +0100, Patrick Bellasi wrote: > On 05-Jun 17:31, Juri Lelli wrote: > > On 05/06/18 16:11, Patrick Bellasi wrote: > > > > [...] > > > > > If I run an experiment with your example above, while using the > > > performance governor to rule out any possible scale

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 05:54:31PM +0100, Patrick Bellasi wrote: > On 05-Jun 17:31, Juri Lelli wrote: > > On 05/06/18 16:11, Patrick Bellasi wrote: > > > > [...] > > > > > If I run an experiment with your example above, while using the > > > performance governor to rule out any possible scale

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 12:33:17PM -0700, Joel Fernandes wrote: > On Tue, Jun 05, 2018 at 04:21:56PM +0100, Patrick Bellasi wrote: [..] > > To be more precise, at each ___update_load_avg we should really update > > running_avg by: > > > >u32 divider = LOAD_AVG_MAX - 1024 + sa->period_contrib;

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 12:33:17PM -0700, Joel Fernandes wrote: > On Tue, Jun 05, 2018 at 04:21:56PM +0100, Patrick Bellasi wrote: [..] > > To be more precise, at each ___update_load_avg we should really update > > running_avg by: > > > >u32 divider = LOAD_AVG_MAX - 1024 + sa->period_contrib;

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 04:21:56PM +0100, Patrick Bellasi wrote: [..] > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > > index f74441be3f44..5d54d6a4c31f 100644 > > > --- a/kernel/sched/fair.c > > > +++ b/kernel/sched/fair.c > > > @@ -3161,6 +3161,8 @@ accumulate_sum(u64 delta, int

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Joel Fernandes
On Tue, Jun 05, 2018 at 04:21:56PM +0100, Patrick Bellasi wrote: [..] > > > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c > > > index f74441be3f44..5d54d6a4c31f 100644 > > > --- a/kernel/sched/fair.c > > > +++ b/kernel/sched/fair.c > > > @@ -3161,6 +3161,8 @@ accumulate_sum(u64 delta, int

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
On 05-Jun 17:31, Juri Lelli wrote: > On 05/06/18 16:11, Patrick Bellasi wrote: > > [...] > > > If I run an experiment with your example above, while using the > > performance governor to rule out any possible scale invariance > > difference, here is what I measure: > > > >Task1 (40ms

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
On 05-Jun 17:31, Juri Lelli wrote: > On 05/06/18 16:11, Patrick Bellasi wrote: > > [...] > > > If I run an experiment with your example above, while using the > > performance governor to rule out any possible scale invariance > > difference, here is what I measure: > > > >Task1 (40ms

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Juri Lelli
On 05/06/18 16:11, Patrick Bellasi wrote: [...] > If I run an experiment with your example above, while using the > performance governor to rule out any possible scale invariance > difference, here is what I measure: > >Task1 (40ms delayed by the following Task2): >

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Juri Lelli
On 05/06/18 16:11, Patrick Bellasi wrote: [...] > If I run an experiment with your example above, while using the > performance governor to rule out any possible scale invariance > difference, here is what I measure: > >Task1 (40ms delayed by the following Task2): >

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
On 04-Jun 10:46, Joel Fernandes wrote: > Hi Patrick, > > On Mon, Jun 04, 2018 at 05:06:00PM +0100, Patrick Bellasi wrote: > > The estimated utilization of a task is affected by the task being > > preempted, either by another FAIR task of by a task of an higher > > priority class (i.e. RT or DL).

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
On 04-Jun 10:46, Joel Fernandes wrote: > Hi Patrick, > > On Mon, Jun 04, 2018 at 05:06:00PM +0100, Patrick Bellasi wrote: > > The estimated utilization of a task is affected by the task being > > preempted, either by another FAIR task of by a task of an higher > > priority class (i.e. RT or DL).

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
Hi Vincent, On 05-Jun 08:57, Vincent Guittot wrote: > On 4 June 2018 at 18:06, Patrick Bellasi wrote: [...] > > Let's improve the estimated utilization by adding a new "sort-of" PELT > > signal, explicitly only for SE which has the following behavior: > > a) at each enqueue time of a task,

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Patrick Bellasi
Hi Vincent, On 05-Jun 08:57, Vincent Guittot wrote: > On 4 June 2018 at 18:06, Patrick Bellasi wrote: [...] > > Let's improve the estimated utilization by adding a new "sort-of" PELT > > signal, explicitly only for SE which has the following behavior: > > a) at each enqueue time of a task,

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Vincent Guittot
On 4 June 2018 at 18:06, Patrick Bellasi wrote: > The estimated utilization of a task is affected by the task being > preempted, either by another FAIR task of by a task of an higher > priority class (i.e. RT or DL). Indeed, when a preemption happens, the > PELT utilization of the preempted task

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-05 Thread Vincent Guittot
On 4 June 2018 at 18:06, Patrick Bellasi wrote: > The estimated utilization of a task is affected by the task being > preempted, either by another FAIR task of by a task of an higher > priority class (i.e. RT or DL). Indeed, when a preemption happens, the > PELT utilization of the preempted task

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread kbuild test robot
Hi Patrick, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on next-20180604] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread kbuild test robot
Hi Patrick, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on next-20180604] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread kbuild test robot
Hi Patrick, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on next-20180604] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread kbuild test robot
Hi Patrick, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on next-20180604] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread Joel Fernandes
Hi Patrick, On Mon, Jun 04, 2018 at 05:06:00PM +0100, Patrick Bellasi wrote: > The estimated utilization of a task is affected by the task being > preempted, either by another FAIR task of by a task of an higher > priority class (i.e. RT or DL). Indeed, when a preemption happens, the > PELT

Re: [PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread Joel Fernandes
Hi Patrick, On Mon, Jun 04, 2018 at 05:06:00PM +0100, Patrick Bellasi wrote: > The estimated utilization of a task is affected by the task being > preempted, either by another FAIR task of by a task of an higher > priority class (i.e. RT or DL). Indeed, when a preemption happens, the > PELT

[PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread Patrick Bellasi
The estimated utilization of a task is affected by the task being preempted, either by another FAIR task of by a task of an higher priority class (i.e. RT or DL). Indeed, when a preemption happens, the PELT utilization of the preempted task is going to be decayed a bit. That's actually correct for

[PATCH 2/2] sched/fair: util_est: add running_sum tracking

2018-06-04 Thread Patrick Bellasi
The estimated utilization of a task is affected by the task being preempted, either by another FAIR task of by a task of an higher priority class (i.e. RT or DL). Indeed, when a preemption happens, the PELT utilization of the preempted task is going to be decayed a bit. That's actually correct for