Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread devendra.aaru
On Thu, Jul 12, 2012 at 2:21 PM, Dan Carpenter wrote: > On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote: >> TCB has kcalloc' ed so no need to call memset again on it. >> > > Gar... What about when this is called from et131x_adjust_link() and > et1310_disable_phy_coma()? > Yeah, i

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread devendra.aaru
On Thu, Jul 12, 2012 at 2:34 PM, Alan Cox wrote: > On Thu, 12 Jul 2012 11:54:28 +0545 > Devendra Naga wrote: > >> TCB has kcalloc' ed so no need to call memset again on it. >> >> Signed-off-by: Devendra Naga >> --- >> drivers/staging/et131x/et131x.c |2 -- >> 1 file changed, 2 deletions(-)

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Alan Cox
On Thu, 12 Jul 2012 11:54:28 +0545 Devendra Naga wrote: > TCB has kcalloc' ed so no need to call memset again on it. > > Signed-off-by: Devendra Naga > --- > drivers/staging/et131x/et131x.c |2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/et131x/et131x.c

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote: > TCB has kcalloc' ed so no need to call memset again on it. > Gar... What about when this is called from et131x_adjust_link() and et1310_disable_phy_coma()? Really this changelog is annoying. Based on the changelog I was

[PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Devendra Naga
TCB has kcalloc' ed so no need to call memset again on it. Signed-off-by: Devendra Naga --- drivers/staging/et131x/et131x.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 227fca9..5010894 100644 ---

[PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Devendra Naga
TCB has kcalloc' ed so no need to call memset again on it. Signed-off-by: Devendra Naga devendra.a...@gmail.com --- drivers/staging/et131x/et131x.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c index 227fca9..5010894

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Dan Carpenter
On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote: TCB has kcalloc' ed so no need to call memset again on it. Gar... What about when this is called from et131x_adjust_link() and et1310_disable_phy_coma()? Really this changelog is annoying. Based on the changelog I was expecting

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread Alan Cox
On Thu, 12 Jul 2012 11:54:28 +0545 Devendra Naga devendra.a...@gmail.com wrote: TCB has kcalloc' ed so no need to call memset again on it. Signed-off-by: Devendra Naga devendra.a...@gmail.com --- drivers/staging/et131x/et131x.c |2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread devendra.aaru
On Thu, Jul 12, 2012 at 2:34 PM, Alan Cox a...@lxorguk.ukuu.org.uk wrote: On Thu, 12 Jul 2012 11:54:28 +0545 Devendra Naga devendra.a...@gmail.com wrote: TCB has kcalloc' ed so no need to call memset again on it. Signed-off-by: Devendra Naga devendra.a...@gmail.com ---

Re: [PATCH 2/2] staging/et131x: remove memset for the TCB

2012-07-12 Thread devendra.aaru
On Thu, Jul 12, 2012 at 2:21 PM, Dan Carpenter dan.carpen...@oracle.com wrote: On Thu, Jul 12, 2012 at 11:54:28AM +0545, Devendra Naga wrote: TCB has kcalloc' ed so no need to call memset again on it. Gar... What about when this is called from et131x_adjust_link() and