RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-21 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Tuesday, August 21, 2018 8:16 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creati

RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-21 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Tuesday, August 21, 2018 8:16 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creati

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-21 Thread Borislav Petkov
On Thu, Aug 16, 2018 at 06:46:33PM +, Ghannam, Yazen wrote: > Future SMCA systems may have banks whose MCA_IPID is not known so we You lost me here. How would the IPID not be known? Are you talking about an old kernel running on new HW and thus the HardwareID in its MCA_IPID to be unknown to

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-21 Thread Borislav Petkov
On Thu, Aug 16, 2018 at 06:46:33PM +, Ghannam, Yazen wrote: > Future SMCA systems may have banks whose MCA_IPID is not known so we You lost me here. How would the IPID not be known? Are you talking about an old kernel running on new HW and thus the HardwareID in its MCA_IPID to be unknown to

RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-16 Thread Ghannam, Yazen
Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL > names > > On Thu, Aug 09, 2018 at 06:46:26PM +, Ghannam, Yazen wrote: > > This patch makes it so that we don't fail init just because some banks don't > > have names. The data caching we do is usefu

RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-16 Thread Ghannam, Yazen
Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL > names > > On Thu, Aug 09, 2018 at 06:46:26PM +, Ghannam, Yazen wrote: > > This patch makes it so that we don't fail init just because some banks don't > > have names. The data caching we do is usefu

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-15 Thread Borislav Petkov
On Thu, Aug 09, 2018 at 06:46:26PM +, Ghannam, Yazen wrote: > This patch makes it so that we don't fail init just because some banks don't > have names. The data caching we do is useful even if we fail to create sysfs > entries for some banks. The interrupt handler can work fine without a

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-15 Thread Borislav Petkov
On Thu, Aug 09, 2018 at 06:46:26PM +, Ghannam, Yazen wrote: > This patch makes it so that we don't fail init just because some banks don't > have names. The data caching we do is useful even if we fail to create sysfs > entries for some banks. The interrupt handler can work fine without a

RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Ghannam, Yazen
Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL > names > > On Thu, Aug 09, 2018 at 09:08:34AM -0500, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > During mce_threshold_create_device() data structures are allocated for > > each CPUs

RE: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Ghannam, Yazen
Subject: Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL > names > > On Thu, Aug 09, 2018 at 09:08:34AM -0500, Yazen Ghannam wrote: > > From: Yazen Ghannam > > > > During mce_threshold_create_device() data structures are allocated for > > each CPUs

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Borislav Petkov
On Thu, Aug 09, 2018 at 09:08:34AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > During mce_threshold_create_device() data structures are allocated for > each CPUs MCA banks and thresholding blocks. These data structures are > used to save information related to AMD's MCA Error

Re: [PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Borislav Petkov
On Thu, Aug 09, 2018 at 09:08:34AM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > During mce_threshold_create_device() data structures are allocated for > each CPUs MCA banks and thresholding blocks. These data structures are > used to save information related to AMD's MCA Error

[PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Yazen Ghannam
From: Yazen Ghannam During mce_threshold_create_device() data structures are allocated for each CPUs MCA banks and thresholding blocks. These data structures are used to save information related to AMD's MCA Error Thresholding feature. The structures are used in the thresholding interrupt

[PATCH 2/2] x86/MCE/AMD: Skip creating kobjects with NULL names

2018-08-09 Thread Yazen Ghannam
From: Yazen Ghannam During mce_threshold_create_device() data structures are allocated for each CPUs MCA banks and thresholding blocks. These data structures are used to save information related to AMD's MCA Error Thresholding feature. The structures are used in the thresholding interrupt