Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-10 Thread Thomas Gleixner
On Wed, 10 Jul 2019, Pingfan Liu wrote: > On Tue, Jul 9, 2019 at 9:34 PM Andy Lutomirski wrote: > > > > Go for it. I’m not familiar enough with the SMP boot stuff that I would > > be able to do it any faster than you. I’ll gladly help review it. > > I had sent out a patch to fix maxcpus "[PATCH]

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-10 Thread Pingfan Liu
On Tue, Jul 9, 2019 at 9:34 PM Andy Lutomirski wrote: > > > > > On Jul 9, 2019, at 1:24 AM, Pingfan Liu wrote: > > > >> On Tue, Jul 9, 2019 at 2:12 PM Thomas Gleixner wrote: > >> > >>> On Tue, 9 Jul 2019, Pingfan Liu wrote: > On Mon, Jul 8, 2019 at 5:35 PM Thomas Gleixner > wrote: >

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-09 Thread Andy Lutomirski
> On Jul 9, 2019, at 1:24 AM, Pingfan Liu wrote: > >> On Tue, Jul 9, 2019 at 2:12 PM Thomas Gleixner wrote: >> >>> On Tue, 9 Jul 2019, Pingfan Liu wrote: On Mon, Jul 8, 2019 at 5:35 PM Thomas Gleixner wrote: It can and it does. That's the whole point why we bring up

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-09 Thread Pingfan Liu
On Tue, Jul 9, 2019 at 2:12 PM Thomas Gleixner wrote: > > On Tue, 9 Jul 2019, Pingfan Liu wrote: > > On Mon, Jul 8, 2019 at 5:35 PM Thomas Gleixner wrote: > > > It can and it does. > > > > > > That's the whole point why we bring up all CPUs in the 'nosmt' case and > > > shut the siblings down

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-09 Thread Thomas Gleixner
On Tue, 9 Jul 2019, Pingfan Liu wrote: > On Mon, Jul 8, 2019 at 5:35 PM Thomas Gleixner wrote: > > It can and it does. > > > > That's the whole point why we bring up all CPUs in the 'nosmt' case and > > shut the siblings down again after setting CR4.MCE. Actually that's in fact > > a 'let's hope

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Pingfan Liu
On Tue, Jul 9, 2019 at 1:53 AM Andy Lutomirski wrote: > > > > > On Jul 8, 2019, at 3:35 AM, Thomas Gleixner wrote: > > > >> On Mon, 8 Jul 2019, Pingfan Liu wrote: > >>> On Mon, Jul 8, 2019 at 3:44 AM Thomas Gleixner wrote: > >>> > On Fri, 5 Jul 2019, Pingfan Liu wrote: > > I hit

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Pingfan Liu
On Mon, Jul 8, 2019 at 5:35 PM Thomas Gleixner wrote: > > On Mon, 8 Jul 2019, Pingfan Liu wrote: > > On Mon, Jul 8, 2019 at 3:44 AM Thomas Gleixner wrote: > > > > > > On Fri, 5 Jul 2019, Pingfan Liu wrote: > > > > > > > I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus > >

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Thomas Gleixner
On Mon, 8 Jul 2019, Andy Lutomirski wrote: > > On Jul 8, 2019, at 3:35 AM, Thomas Gleixner wrote: > > Anything less than the actual number of present CPUs is problematic except > > you use the 'let's hope nothing happens' approach. We could add an option > > to stop the bringup at the early

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Andy Lutomirski
> On Jul 8, 2019, at 3:35 AM, Thomas Gleixner wrote: > >> On Mon, 8 Jul 2019, Pingfan Liu wrote: >>> On Mon, Jul 8, 2019 at 3:44 AM Thomas Gleixner wrote: >>> On Fri, 5 Jul 2019, Pingfan Liu wrote: I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Thomas Gleixner
On Mon, 8 Jul 2019, Pingfan Liu wrote: > On Mon, Jul 8, 2019 at 3:44 AM Thomas Gleixner wrote: > > > > On Fri, 5 Jul 2019, Pingfan Liu wrote: > > > > > I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus > > > option > > > is used to speed up kdump process, so it is not a rare

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-08 Thread Pingfan Liu
On Mon, Jul 8, 2019 at 3:44 AM Thomas Gleixner wrote: > > On Fri, 5 Jul 2019, Pingfan Liu wrote: > > > I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus > > option > > is used to speed up kdump process, so it is not a rare case. > > But fundamentally wrong, really. > > The

Re: [PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-07 Thread Thomas Gleixner
On Fri, 5 Jul 2019, Pingfan Liu wrote: > I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus option > is used to speed up kdump process, so it is not a rare case. But fundamentally wrong, really. The rest of the CPUs are in a half baken state and any broadcast event, e.g. MCE

[PATCH 2/2] x86/numa: instance all parsed numa node

2019-07-04 Thread Pingfan Liu
I hit a bug on an AMD machine, with kexec -l nr_cpus=4 option. nr_cpus option is used to speed up kdump process, so it is not a rare case. It turns out that some pgdat is not instanced when specifying nr_cpus, e.g, on x86, not initialized by init_cpu_to_node()->init_memory_less_node(). But