Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-19 Thread Mark Brown
On Thu, Apr 19, 2018 at 01:04:16PM +0300, Radu Pirea wrote: > Thank you for suggestions. I followed your advice and looked at PXA SSP > driver. In my opinion it is a layer that avoids collsions and > unfortunately complicates things a bit. My ideea is to keep the things > as simple as possible. Fo

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-19 Thread Mark Brown
On Thu, Apr 19, 2018 at 03:32:33PM +0200, Alexandre Belloni wrote: > My suggestion was to add an MFD driver that would match the current > compatible and either have an atmel,usart-mode property or maybe more > risky, check whether there are children nodes. Based on that, the > correct platform de

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-19 Thread Alexandre Belloni
On 17/04/2018 12:03:58+0100, Mark Brown wrote: > On Fri, Apr 13, 2018 at 08:12:51PM +0200, Alexandre Belloni wrote: > > On 13/04/2018 19:12:54+0200, Nicolas Ferre wrote: > > > > This layout of the hardware is completely different from the USART one and > > > it seems to makes sense to address it w

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-19 Thread Radu Pirea
On Tue, 2018-04-17 at 12:03 +0100, Mark Brown wrote: > On Fri, Apr 13, 2018 at 08:12:51PM +0200, Alexandre Belloni wrote: > > On 13/04/2018 19:12:54+0200, Nicolas Ferre wrote: > > > This layout of the hardware is completely different from the > > > USART one and > > > it seems to makes sense to add

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-17 Thread Mark Brown
On Fri, Apr 13, 2018 at 08:12:51PM +0200, Alexandre Belloni wrote: > On 13/04/2018 19:12:54+0200, Nicolas Ferre wrote: > > This layout of the hardware is completely different from the USART one and > > it seems to makes sense to address it with a different hardware description > > and so a differe

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-13 Thread Alexandre Belloni
On 13/04/2018 19:12:54+0200, Nicolas Ferre wrote: > > > diff --git > > > a/Documentation/devicetree/bindings/spi/microchip,at91-usart-spi.txt > > > b/Documentation/devicetree/bindings/spi/microchip,at91-usart-spi.txt > > > new file mode 100644 > > > index ..92d33ccdffae > > > --- /dev

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-13 Thread Nicolas Ferre
On 13/04/2018 at 18:23, Alexandre Belloni wrote: On 13/04/2018 19:11:16+0300, Radu Pirea wrote: These are bindings for at91-usart IP in spi spi mode. There is no support for internal chip select. Only kind of chip selects available are gpio chip selects. Signed-off-by: Radu Pirea --- .../bin

Re: [PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-13 Thread Alexandre Belloni
On 13/04/2018 19:11:16+0300, Radu Pirea wrote: > These are bindings for at91-usart IP in spi spi mode. There is no support for > internal chip select. Only kind of chip selects available are gpio chip > selects. > > Signed-off-by: Radu Pirea > --- > .../bindings/spi/microchip,at91-usart-spi.txt

[PATCH 2/3] dt-bindings: add binding for at91-usart in spi mode

2018-04-13 Thread Radu Pirea
These are bindings for at91-usart IP in spi spi mode. There is no support for internal chip select. Only kind of chip selects available are gpio chip selects. Signed-off-by: Radu Pirea --- .../bindings/spi/microchip,at91-usart-spi.txt | 24 +++ 1 file changed, 24 insertions(+) c