Re: [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface

2014-02-24 Thread Corey Minyard
On 02/24/2014 10:57 AM, Dmitry Torokhov wrote: > On Sun, Feb 23, 2014 at 08:23:35PM -0600, miny...@acm.org wrote: >> @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val) >> INIT_LIST_HEAD(&msgs); >> >> spin_lock_irqsave(&intf->events_lock, flags); >> -user->get

Re: [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface

2014-02-24 Thread Dmitry Torokhov
On Sun, Feb 23, 2014 at 08:23:35PM -0600, miny...@acm.org wrote: > @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val) > INIT_LIST_HEAD(&msgs); > > spin_lock_irqsave(&intf->events_lock, flags); > - user->gets_events = val; > + if (user->gets_events == !!

[PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface

2014-02-23 Thread minyard
From: Corey Minyard The IPMI driver would wake up periodically looking for events and watchdog pretimeouts. If there is nothing waiting for these events, it's really kind of pointless to be checking for them. So modify the driver so the message handler can pass down if it needs the lower layer