Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Doug Anderson
Hi, On Tue, May 28, 2019 at 4:45 AM Adrian Hunter wrote: > > On 28/05/19 2:21 PM, Arend Van Spriel wrote: > > > > > > On 5/28/2019 12:04 PM, Adrian Hunter wrote: > >> On 26/05/19 9:42 PM, Arend Van Spriel wrote: > >>> On 5/18/2019 12:54 AM, Douglas Anderson wrote: > Normally when the MMC

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Adrian Hunter
On 28/05/19 2:21 PM, Arend Van Spriel wrote: > > > On 5/28/2019 12:04 PM, Adrian Hunter wrote: >> On 26/05/19 9:42 PM, Arend Van Spriel wrote: >>> On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Arend Van Spriel
On 5/28/2019 12:04 PM, Adrian Hunter wrote: On 26/05/19 9:42 PM, Arend Van Spriel wrote: On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card.  This is generally a good

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-28 Thread Adrian Hunter
On 26/05/19 9:42 PM, Arend Van Spriel wrote: > On 5/18/2019 12:54 AM, Douglas Anderson wrote: >> Normally when the MMC core sees an "-EILSEQ" error returned by a host >> controller then it will trigger a retuning of the card.  This is >> generally a good idea. > > Probably a question for Adrian,

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-26 Thread Arend Van Spriel
On 5/18/2019 12:54 AM, Douglas Anderson wrote: Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card. This is generally a good idea. Probably a question for Adrian, but how is this retuning scheduled. I recall seeing

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-20 Thread Wolfram Sang
On Mon, May 20, 2019 at 10:46:19AM +0200, Arend Van Spriel wrote: > On 5/19/2019 11:06 AM, Wolfram Sang wrote: > > > > > Let's add an API that the SDIO card drivers can call that will > > > temporarily disable the auto-tuning functionality. Then we can add a > > > call to this in the Broadcom

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-20 Thread Arend Van Spriel
On 5/19/2019 11:06 AM, Wolfram Sang wrote: Let's add an API that the SDIO card drivers can call that will temporarily disable the auto-tuning functionality. Then we can add a call to this in the Broadcom WiFi driver and any other driver that might have similar needs. Can't you fix the WiFi

Re: [PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-19 Thread Wolfram Sang
> Let's add an API that the SDIO card drivers can call that will > temporarily disable the auto-tuning functionality. Then we can add a > call to this in the Broadcom WiFi driver and any other driver that > might have similar needs. Can't you fix the WiFi driver to return something else than

[PATCH 2/3] mmc: core: API for temporarily disabling auto-retuning due to errors

2019-05-17 Thread Douglas Anderson
Normally when the MMC core sees an "-EILSEQ" error returned by a host controller then it will trigger a retuning of the card. This is generally a good idea. However, if a command is expected to sometimes cause transfer errors then these transfer errors shouldn't cause a re-tuning. This