Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-06 Thread Jarkko Sakkinen
On Mon, 2018-03-05 at 14:07 -0500, Mimi Zohar wrote: > On Mon, 2018-03-05 at 20:01 +0200, Jarkko Sakkinen wrote: > > On Mon, Mar 05, 2018 at 12:56:33PM +0200, Jarkko Sakkinen wrote: > > > On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > > > > > > > > > > On 03/01/2018 02:52 PM, J

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-05 Thread Mimi Zohar
On Mon, 2018-03-05 at 20:01 +0200, Jarkko Sakkinen wrote: > On Mon, Mar 05, 2018 at 12:56:33PM +0200, Jarkko Sakkinen wrote: > > On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > > > > > > > On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: > > > > On Wed, Feb 28, 2018 at 02:18:27PM

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-05 Thread Jarkko Sakkinen
On Mon, Mar 05, 2018 at 12:56:33PM +0200, Jarkko Sakkinen wrote: > On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > > > > On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: > > > On Wed, Feb 28, 2018 at 02:18:27PM -0500, Nayna Jain wrote: > > > > In tpm_transmit, after send(), the co

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-05 Thread Jarkko Sakkinen
On Fri, Mar 02, 2018 at 12:26:35AM +0530, Nayna Jain wrote: > > > On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: > > On Wed, Feb 28, 2018 at 02:18:27PM -0500, Nayna Jain wrote: > > > In tpm_transmit, after send(), the code checks for status in a loop > > Maybe cutting hairs now but please just us

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-01 Thread Nayna Jain
On 03/01/2018 02:52 PM, Jarkko Sakkinen wrote: On Wed, Feb 28, 2018 at 02:18:27PM -0500, Nayna Jain wrote: In tpm_transmit, after send(), the code checks for status in a loop Maybe cutting hairs now but please just use the actual function name instead of send(). Just makes the commit log more

Re: [PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-03-01 Thread Jarkko Sakkinen
On Wed, Feb 28, 2018 at 02:18:27PM -0500, Nayna Jain wrote: > In tpm_transmit, after send(), the code checks for status in a loop Maybe cutting hairs now but please just use the actual function name instead of send(). Just makes the commit log more useful asset. > - tpm_msleep(TPM_TIM

[PATCH 2/3] tpm: reduce poll sleep time between send() and recv() in tpm_transmit()

2018-02-28 Thread Nayna Jain
In tpm_transmit, after send(), the code checks for status in a loop with polling every 5msec. It is expected that the tpm might return earlier than 5msec, so it might be adding to unnecessary delay. This patch reduces the polling sleep time from 5msec to 1msec. After this change, performance on a