Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-22 Thread Rusty Russell
On Thu, 2007-03-22 at 09:10 +0100, Sébastien Dugué wrote: > Why not take on the opportunity to rename boot_gt_table to boot_gtd, > to avoid the duplicate T(able)? That's not a bad idea, but IMHO deserves its own patch. I look forward to it! Rusty. - To unsubscribe from this list: send the lin

Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-22 Thread Sébastien Dugué
Hi Rusty, On Thu, 22 Mar 2007 10:58:30 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Wed, 2007-03-21 at 10:51 -0600, Eric W. Biederman wrote: > > Rusty Russell <[EMAIL PROTECTED]> writes: > > > > > On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote: > > >> Rusty Russell <[EMAIL

Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 10:51 -0600, Eric W. Biederman wrote: > Rusty Russell <[EMAIL PROTECTED]> writes: > > > On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote: > >> Rusty Russell <[EMAIL PROTECTED]> writes: > >> > -/* > >> > - * The boot_gdt_table must mirror the equivalent in setup.S an

Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-21 Thread Eric W. Biederman
Rusty Russell <[EMAIL PROTECTED]> writes: > On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote: >> Rusty Russell <[EMAIL PROTECTED]> writes: >> > -/* >> > - * The boot_gdt_table must mirror the equivalent in setup.S and is >> > - * used only for booting. >> > - */ >> >> It looks like you

Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-21 Thread Rusty Russell
On Wed, 2007-03-21 at 03:31 -0600, Eric W. Biederman wrote: > Rusty Russell <[EMAIL PROTECTED]> writes: > > -/* > > - * The boot_gdt_table must mirror the equivalent in setup.S and is > > - * used only for booting. > > - */ > > It looks like you are killing a useful comment here for no good reason

Re: [PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-21 Thread Eric W. Biederman
Rusty Russell <[EMAIL PROTECTED]> writes: > Now we are no longer dynamically allocating the GDT, we don't need the > "cpu_gdt_table" at all: we can switch straight from "boot_gdt_table" > to the per-cpu GDT. This means initializing the cpu_gdt array in C. > > The boot CPU uses the per-cpu var dir

[PATCH 2/4] i386 GDT cleanups: Use per-cpu GDT immediately upon boot

2007-03-20 Thread Rusty Russell
Now we are no longer dynamically allocating the GDT, we don't need the "cpu_gdt_table" at all: we can switch straight from "boot_gdt_table" to the per-cpu GDT. This means initializing the cpu_gdt array in C. The boot CPU uses the per-cpu var directly, then in smp_prepare_cpus() it switches to the