Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Hi, On Mon, Feb 15, 2021 at 01:19:18PM +0100, Arnd Bergmann wrote: > On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > > > Sorry, I sent the wrong patchset that didn't fix this point out. > > > > > > > I asked it

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Nobuhiro Iwamatsu
Hi, On Mon, Feb 15, 2021 at 11:22:33AM +0200, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > I have received your point out and have sent an email with the content > > to remove this line. But it may not have arrived yet... > > > > > Why did you

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Arnd Bergmann
On Mon, Feb 15, 2021 at 10:23 AM Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > > > > Sorry, I sent the wrong patchset that didn't fix this point out. > > > > > I asked it before, but never received an answer. > > > > I have received your point out an

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-15 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 04:28:09PM +0900, Nobuhiro Iwamatsu wrote: > Hi, > > Thanks for your review. > > On Mon, Feb 15, 2021 at 08:07:21AM +0200, Leon Romanovsky wrote: > > On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > > > Add dwmac-visconti to the stmmac driver in Toshiba V

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-14 Thread Nobuhiro Iwamatsu
Hi, Thanks for your review. On Mon, Feb 15, 2021 at 08:07:21AM +0200, Leon Romanovsky wrote: > On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > > This patch contains only the basic function of the device

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-14 Thread Leon Romanovsky
On Mon, Feb 15, 2021 at 02:06:53PM +0900, Nobuhiro Iwamatsu wrote: > Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. > This patch contains only the basic function of the device. There is no > clock control, PM, etc. yet. These will be added in the future. > > Signed-off-by: No

[PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-14 Thread Nobuhiro Iwamatsu
Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. This patch contains only the basic function of the device. There is no clock control, PM, etc. yet. These will be added in the future. Signed-off-by: Nobuhiro Iwamatsu --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 +

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread Nobuhiro Iwamatsu
Hi, Thanks for your comment. On Thu, Feb 11, 2021 at 02:13:07PM -0800, David Miller wrote: > From: Nobuhiro Iwamatsu > Date: Thu, 11 Feb 2021 01:29:52 +0900 > > > +static int visconti_eth_init_hw(struct platform_device *pdev, struct > > plat_stmmacenet_data *plat_dat) > > +{ > > + struct vis

Re: [PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-11 Thread David Miller
From: Nobuhiro Iwamatsu Date: Thu, 11 Feb 2021 01:29:52 +0900 > +static int visconti_eth_init_hw(struct platform_device *pdev, struct > plat_stmmacenet_data *plat_dat) > +{ > + struct visconti_eth *dwmac; > + unsigned int reg_val, clk_sel_val; Please use reverse christmas tree ordering

[PATCH 2/4] net: stmmac: Add Toshiba Visconti SoCs glue driver

2021-02-10 Thread Nobuhiro Iwamatsu
Add dwmac-visconti to the stmmac driver in Toshiba Visconti ARM SoCs. This patch contains only the basic function of the device. There is no clock control, PM, etc. yet. These will be added in the future. Signed-off-by: Nobuhiro Iwamatsu --- drivers/net/ethernet/stmicro/stmmac/Kconfig | 8 +