Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-24 Thread Boris Petkov
Aravind Gopalakrishnan wrote: >Should I change that as well and move it to mce.h? Yes please. -- Sent from a small device: formatting sux and brevity is inevitable.

Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-24 Thread Aravind Gopalakrishnan
On 2/24/2016 5:33 AM, Borislav Petkov wrote: On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote: I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well. So might be better to retain it here. Actually, I'm thinking, these all are - even if used in multiple files

Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-24 Thread Borislav Petkov
On Tue, Feb 23, 2016 at 04:56:38PM -0600, Aravind Gopalakrishnan wrote: > I think MSR_AMD64_SMCA_MC0_MISC0 would be required in mce.c as well. > So might be better to retain it here. Actually, I'm thinking, these all are - even if used in multiple files - all MCE-specific and therefore used in MCE

Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-23 Thread Aravind Gopalakrishnan
On 2/23/16 6:39 AM, Borislav Petkov wrote: On Tue, Feb 16, 2016 at 03:45:09PM -0600, Aravind Gopalakrishnan wrote: /* 'SMCA': AMD64 Scalable MCA */ +#define MSR_AMD64_SMCA_MC0_MISC0 0xc0002003 #define MSR_AMD64_SMCA_MC0_CONFIG 0xc0002004 #define MSR_AMD64_SMCA_MC0_IPID

Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-23 Thread Borislav Petkov
On Tue, Feb 16, 2016 at 03:45:09PM -0600, Aravind Gopalakrishnan wrote: > In upcoming processors, the BLKPTR field is no longer used > to indicate the MSR number of the additional register. > Insted, it simply indicates the prescence of additional MSRs. > > Fixing the logic here to gather MSR addr

Re: [PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-18 Thread Aravind Gopalakrishnan
On 2/16/2016 3:45 PM, Aravind Gopalakrishnan wrote: In upcoming processors, the BLKPTR field is no longer used to indicate the MSR number of the additional register. Insted, it simply indicates the prescence of additional MSRs. Fixing the logic here to gather MSR address from MSR_AMD64_SMCA_MCx_

[PATCH 2/4] x86/mce/AMD: Fix logic to obtain block address

2016-02-16 Thread Aravind Gopalakrishnan
In upcoming processors, the BLKPTR field is no longer used to indicate the MSR number of the additional register. Insted, it simply indicates the prescence of additional MSRs. Fixing the logic here to gather MSR address from MSR_AMD64_SMCA_MCx_MISC() for newer processors and we fall back to existi