Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-10 Thread Srinivas Kandagatla
On 09/06/2020 12:04, Jonathan Marek wrote: On 6/9/20 5:19 AM, Srinivas Kandagatla wrote: On 08/06/2020 21:43, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. Signed-off-by: Jonathan Marek --- In general patch itself looks pretty trivial, b

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-09 Thread Jonathan Marek
On 6/9/20 5:18 AM, Srinivas Kandagatla wrote: On 09/06/2020 05:34, Vinod Koul wrote: Hi Jonathan, On 08-06-20, 16:43, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. Please use 'SoundWire Master devices' instead :) Signed-off-by: Jonathan M

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-09 Thread Jonathan Marek
On 6/9/20 5:19 AM, Srinivas Kandagatla wrote: On 08/06/2020 21:43, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. Signed-off-by: Jonathan Marek --- In general patch itself looks pretty trivial, but I would like to see what 1.5.1 controller p

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-09 Thread Srinivas Kandagatla
On 08/06/2020 21:43, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. Signed-off-by: Jonathan Marek --- In general patch itself looks pretty trivial, but I would like to see what 1.5.1 controller provides in terms of error reporting of SoundWi

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-09 Thread Srinivas Kandagatla
On 09/06/2020 05:34, Vinod Koul wrote: Hi Jonathan, On 08-06-20, 16:43, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. Please use 'SoundWire Master devices' instead :) Signed-off-by: Jonathan Marek --- drivers/soundwire/qcom.c | 25

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-08 Thread Vinod Koul
Hi Jonathan, On 08-06-20, 16:43, Jonathan Marek wrote: > Adds support for qcom soundwire devices with memory mapped IO registers. Please use 'SoundWire Master devices' instead :) > > Signed-off-by: Jonathan Marek > --- > drivers/soundwire/qcom.c | 25 +++-- > 1 file change

Re: [PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-08 Thread Pierre-Louis Bossart
On 6/8/20 3:43 PM, Jonathan Marek wrote: Adds support for qcom soundwire devices with memory mapped IO registers. 'device' is an ambiguous term for SoundWire. Seems to me this is a SoundWire Master device directly accessed with mmio registers instead of over a SLIMbus link? Signed-off-

[PATCH 2/5] soundwire: qcom: add support for mmio soundwire devices

2020-06-08 Thread Jonathan Marek
Adds support for qcom soundwire devices with memory mapped IO registers. Signed-off-by: Jonathan Marek --- drivers/soundwire/qcom.c | 25 +++-- 1 file changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c index f38d1fd3679