Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only

2013-10-31 Thread Namhyung Kim
On Tue, 29 Oct 2013 13:28:46 +0400, Stanislav Fomichev wrote: >> I don't see how it does same thing. You mean it by skipping >> draw_process_bars() and draw_wakeups() on patch 1? It'd be better >> changelog explains the details. > Yes, it depends on the previous patch, I'll add more info to the >

Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only

2013-10-29 Thread Stanislav Fomichev
> I don't see how it does same thing. You mean it by skipping > draw_process_bars() and draw_wakeups() on patch 1? It'd be better > changelog explains the details. Yes, it depends on the previous patch, I'll add more info to the changelog. > And I'd like to keep it as BOOLEAN option - it's simpl

Re: [PATCH 2/6] perf timechart: use proc_num to implement --power-only

2013-10-29 Thread Namhyung Kim
On Tue, 22 Oct 2013 14:56:48 +0400, Stanislav Fomichev wrote: > Don't use special flag to indicate power-only mode, use proc_num == 0. > -P now equals to -n 0 I don't see how it does same thing. You mean it by skipping draw_process_bars() and draw_wakeups() on patch 1? It'd be better changelog e

[PATCH 2/6] perf timechart: use proc_num to implement --power-only

2013-10-22 Thread Stanislav Fomichev
Don't use special flag to indicate power-only mode, use proc_num == 0. -P now equals to -n 0 Signed-off-by: Stanislav Fomichev --- tools/perf/builtin-timechart.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/tools/perf/builtin-timechart.c b/tools/perf/bu