Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Kevin Hilman
Yixun Lan writes: > On 07/19/2018 10:06 PM, Kevin Hilman wrote: >> Yixun Lan writes: >> >> [...] >> As Jerome said, I think consistency is an important goal, so leaving off the "meson-" for drivers/clk is fine with me. >>> ok >>> Also for consistency, for the rest of

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Kevin Hilman
Yixun Lan writes: > On 07/19/2018 10:06 PM, Kevin Hilman wrote: >> Yixun Lan writes: >> >> [...] >> As Jerome said, I think consistency is an important goal, so leaving off the "meson-" for drivers/clk is fine with me. >>> ok >>> Also for consistency, for the rest of

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Yixun Lan
On 07/19/2018 10:06 PM, Kevin Hilman wrote: > Yixun Lan writes: > > [...] > >>> >>> As Jerome said, I think consistency is an important goal, so leaving off >>> the "meson-" for drivers/clk is fine with me. >>> >> ok >> >>> Also for consistency, for the rest of the drivers, keeping "meson-" is

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Yixun Lan
On 07/19/2018 10:06 PM, Kevin Hilman wrote: > Yixun Lan writes: > > [...] > >>> >>> As Jerome said, I think consistency is an important goal, so leaving off >>> the "meson-" for drivers/clk is fine with me. >>> >> ok >> >>> Also for consistency, for the rest of the drivers, keeping "meson-" is

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Kevin Hilman
Yixun Lan writes: [...] >> >> As Jerome said, I think consistency is an important goal, so leaving off >> the "meson-" for drivers/clk is fine with me. >> > ok > >> Also for consistency, for the rest of the drivers, keeping "meson-" is >> probably the right thing to do. >> > ok, for the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-19 Thread Kevin Hilman
Yixun Lan writes: [...] >> >> As Jerome said, I think consistency is an important goal, so leaving off >> the "meson-" for drivers/clk is fine with me. >> > ok > >> Also for consistency, for the rest of the drivers, keeping "meson-" is >> probably the right thing to do. >> > ok, for the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Yixun Lan
HI Kevin just want to clarify.. On 07/16/18 21:38, Kevin Hilman wrote: > Jerome Brunet writes: > >> On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >>> >>> On 07/10/18 05:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: > > [...] > > + > +static

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Yixun Lan
HI Kevin just want to clarify.. On 07/16/18 21:38, Kevin Hilman wrote: > Jerome Brunet writes: > >> On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >>> >>> On 07/10/18 05:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: > > [...] > > + > +static

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Kevin Hilman
Jian Hu writes: > On 2018/7/10 5:53, Martin Blumenstingl wrote: >> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: [...] >>> +static const struct of_device_id clkc_match_table[] = { >>> + { .compatible = "amlogic,g12a-clkc" }, >> I wonder if that should be "amlogic,meson-g12a-clkc" (I

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Kevin Hilman
Jian Hu writes: > On 2018/7/10 5:53, Martin Blumenstingl wrote: >> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: [...] >>> +static const struct of_device_id clkc_match_table[] = { >>> + { .compatible = "amlogic,g12a-clkc" }, >> I wonder if that should be "amlogic,meson-g12a-clkc" (I

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Kevin Hilman
Jerome Brunet writes: > On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >> >> On 07/10/18 05:53, Martin Blumenstingl wrote: >> > On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: [...] >> > > + >> > > +static const struct of_device_id clkc_match_table[] = { >> > > + { .compatible =

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Kevin Hilman
Jerome Brunet writes: > On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >> >> On 07/10/18 05:53, Martin Blumenstingl wrote: >> > On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: [...] >> > > + >> > > +static const struct of_device_id clkc_match_table[] = { >> > > + { .compatible =

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Jian Hu
Hi Jerome On 2018/7/11 21:45, Jerome Brunet wrote: On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote: +static struct clk_regmap g12a_mpll0 = { + .data = &(struct clk_regmap_gate_data){ + .offset = HHI_MPLL_CNTL1, + .bit_idx = 31, + }, + .hw.init =

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-16 Thread Jian Hu
Hi Jerome On 2018/7/11 21:45, Jerome Brunet wrote: On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote: +static struct clk_regmap g12a_mpll0 = { + .data = &(struct clk_regmap_gate_data){ + .offset = HHI_MPLL_CNTL1, + .bit_idx = 31, + }, + .hw.init =

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jerome Brunet
On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote: > > > > > +static struct clk_regmap g12a_mpll0 = { > > > > > + .data = &(struct clk_regmap_gate_data){ > > > > > + .offset = HHI_MPLL_CNTL1, > > > > > + .bit_idx = 31, > > > > > + }, > > > > > +

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jerome Brunet
On Wed, 2018-07-11 at 21:41 +0800, Jian Hu wrote: > > > > > +static struct clk_regmap g12a_mpll0 = { > > > > > + .data = &(struct clk_regmap_gate_data){ > > > > > + .offset = HHI_MPLL_CNTL1, > > > > > + .bit_idx = 31, > > > > > + }, > > > > > +

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jian Hu
On 2018/7/10 17:54, Jerome Brunet wrote: On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: HI Martin On 07/10/18 05:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the Everyting-Else part of the Amlogic Meson-G12A SoC.

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jian Hu
On 2018/7/10 17:54, Jerome Brunet wrote: On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: HI Martin On 07/10/18 05:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the Everyting-Else part of the Amlogic Meson-G12A SoC.

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jian Hu
On 2018/7/10 5:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the Everyting-Else part of the Amlogic Meson-G12A SoC. Signed-off-by: Jian Hu --- drivers/clk/meson/Kconfig | 10 + drivers/clk/meson/Makefile | 1 +

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-11 Thread Jian Hu
On 2018/7/10 5:53, Martin Blumenstingl wrote: On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the Everyting-Else part of the Amlogic Meson-G12A SoC. Signed-off-by: Jian Hu --- drivers/clk/meson/Kconfig | 10 + drivers/clk/meson/Makefile | 1 +

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Jerome Brunet
On Tue, 2018-07-10 at 20:59 +0800, Yixun Lan wrote: > > > > > +static const struct of_device_id clkc_match_table[] = { > > > > > + { .compatible = "amlogic,g12a-clkc" }, > > > > > > > > I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG > > > > and GXBB/GXL/GXM omit the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Jerome Brunet
On Tue, 2018-07-10 at 20:59 +0800, Yixun Lan wrote: > > > > > +static const struct of_device_id clkc_match_table[] = { > > > > > + { .compatible = "amlogic,g12a-clkc" }, > > > > > > > > I wonder if that should be "amlogic,meson-g12a-clkc" (I know that AXG > > > > and GXBB/GXL/GXM omit the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Yixun Lan
Hi Jerome: just one comment On 07/10/2018 05:54 PM, Jerome Brunet wrote: > On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >> HI Martin >> >> >> On 07/10/18 05:53, Martin Blumenstingl wrote: >>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Yixun Lan
Hi Jerome: just one comment On 07/10/2018 05:54 PM, Jerome Brunet wrote: > On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: >> HI Martin >> >> >> On 07/10/18 05:53, Martin Blumenstingl wrote: >>> On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: Add a Clock driver for the

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Jerome Brunet
On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: > HI Martin > > > On 07/10/18 05:53, Martin Blumenstingl wrote: > > On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: > > > > > > Add a Clock driver for the Everyting-Else part > > > of the Amlogic Meson-G12A SoC. > > > > > > Signed-off-by: Jian

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-10 Thread Jerome Brunet
On Tue, 2018-07-10 at 09:21 +0800, Yixun Lan wrote: > HI Martin > > > On 07/10/18 05:53, Martin Blumenstingl wrote: > > On Mon, Jul 9, 2018 at 1:14 PM Jian Hu wrote: > > > > > > Add a Clock driver for the Everyting-Else part > > > of the Amlogic Meson-G12A SoC. > > > > > > Signed-off-by: Jian

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-09 Thread Stephen Boyd
Quoting Jian Hu (2018-07-09 04:12:47) > Add a Clock driver for the Everyting-Else part Everything instead of Everyting? > of the Amlogic Meson-G12A SoC. > > Signed-off-by: Jian Hu

Re: [PATCH 3/3] clk: meson-g12a: Add EE Clock controller driver

2018-07-09 Thread Stephen Boyd
Quoting Jian Hu (2018-07-09 04:12:47) > Add a Clock driver for the Everyting-Else part Everything instead of Everyting? > of the Amlogic Meson-G12A SoC. > > Signed-off-by: Jian Hu