Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-07 Thread Stefan Schaeckeler (sschaeck)
Hello Troy, > Hi Stefan, > > The driver was ported from latest ASPEED BSP, so I only test with ECC-on/off > from u-boot and check if driver runs correctly. I noticed now most changes are these "exports". As you removed them a later revision, the patch looks now lean and clean. I'll give you my

RE: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-01 Thread Troy Lee
TTENED DEVICE TREE BINDINGS ; moderated > list:ARM/ASPEED MACHINE SUPPORT ; > moderated list:ARM/ASPEED MACHINE SUPPORT > ; open list ; > open list:EDAC-CORE > Cc: leet...@gmail.com; Ryan Chen ; Stefan > Schaeckeler > Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 ed

RE: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-12-01 Thread Troy Lee
MACHINE SUPPORT ; open > list ; open list:EDAC-CORE > > Cc: leet...@gmail.com; Ryan Chen > Subject: Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver > > Hi Troy, > > I like the idea of expanding the driver's support to cover the other SoC > generations, but no

Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-11-30 Thread Andrew Jeffery
Hi Troy, I like the idea of expanding the driver's support to cover the other SoC generations, but not at the cost of making the build of the driver SoC-specific. I've made some comments below in this regard. On Mon, 30 Nov 2020, at 19:03, Troy Lee wrote: > Adding AST2400 and AST2600 edac

Re: [PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-11-30 Thread Stefan Schaeckeler (sschaeck)
Hello Troy, > Adding AST2400 and AST2600 edac driver support. > > Signed-off-by: Troy Lee > --- > drivers/edac/Kconfig | 6 +- > drivers/edac/aspeed_edac.c | 114 + > 2 files changed, 94 insertions(+), 26 deletions(-) Uh, there are quite some

[PATCH 3/3] edac: Supporting AST2400 and AST2600 edac driver

2020-11-30 Thread Troy Lee
Adding AST2400 and AST2600 edac driver support. Signed-off-by: Troy Lee --- drivers/edac/Kconfig | 6 +- drivers/edac/aspeed_edac.c | 114 + 2 files changed, 94 insertions(+), 26 deletions(-) diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig