Jesper Juhl <[EMAIL PROTECTED]> wrote:
> On Wednesday 24 August 2005 22:39, Brian Gerst wrote:
> >
> > Do this instead:
> > char ln[LINE_SIZE], *line;
> >
> Right, now why didn't I think of that :)
>
> Jeff: Does the patch below agree with you more?
>
>
> Signed-off-by: Jesper Juhl <[EMAIL
On Wed, Aug 24, 2005 at 09:08:53PM +0200, Jesper Juhl wrote:
> Convert strtok() use to strsep() in usr/gen_init_cpio.c
>
> I've compile tested this patch and it compiles fine.
> I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and
> the resulting kernel boots and runs just
Horst wrote:
> > - if ('\n' == *type) {
> > + if (!*type || '\n' == *type) {
>
> Redundant. If *type == '\n', it is certainly != 0.
No - I don't think redundant, at least not this change in isolation.
Perhaps redundant in light of subsequent code lines, as Jesper notes in
his
On 8/24/05, Horst von Brand <[EMAIL PROTECTED]> wrote:
> Jesper Juhl <[EMAIL PROTECTED]> wrote:
[snip]
>
> > - if ('\n' == *type) {
> > + if (!*type || '\n' == *type) {
>
> Redundant. If *type == '\n', it is certainly != 0.
Hmm, I added that since if we get past the if ab
On Wednesday 24 August 2005 22:39, Brian Gerst wrote:
>
> Do this instead:
> char ln[LINE_SIZE], *line;
>
Right, now why didn't I think of that :)
Jeff: Does the patch below agree with you more?
Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]>
---
usr/gen_init_cpio.c | 22 +
Jesper Juhl <[EMAIL PROTECTED]> wrote:
> Convert strtok() use to strsep() in usr/gen_init_cpio.c
This is userland code...
No, I'm not looking it over carfully, just a fast look over.
> I've compile tested this patch and it compiles fine.
You should be able ti test it then.
> I build a 2.6.13-r
Jesper Juhl wrote:
On 8/24/05, Jeff Garzik <[EMAIL PROTECTED]> wrote:
Brian Gerst wrote:
Jesper Juhl wrote:
Convert strtok() use to strsep() in usr/gen_init_cpio.c
I've compile tested this patch and it compiles fine.
I build a 2.6.13-rc6-mm2 kernel with the patch applied without
problems,
On 8/24/05, Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Brian Gerst wrote:
> > Jesper Juhl wrote:
> >
> >> Convert strtok() use to strsep() in usr/gen_init_cpio.c
> >>
> >> I've compile tested this patch and it compiles fine.
> >> I build a 2.6.13-rc6-mm2 kernel with the patch applied without
> >> pro
Brian Gerst wrote:
Jesper Juhl wrote:
Convert strtok() use to strsep() in usr/gen_init_cpio.c
I've compile tested this patch and it compiles fine.
I build a 2.6.13-rc6-mm2 kernel with the patch applied without
problems, and
the resulting kernel boots and runs just fine (using it right now).
Jesper Juhl wrote:
Convert strtok() use to strsep() in usr/gen_init_cpio.c
I've compile tested this patch and it compiles fine.
I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and
the resulting kernel boots and runs just fine (using it right now).
But despite this basic
Convert strtok() use to strsep() in usr/gen_init_cpio.c
I've compile tested this patch and it compiles fine.
I build a 2.6.13-rc6-mm2 kernel with the patch applied without problems, and
the resulting kernel boots and runs just fine (using it right now).
But despite this basic testing it would stil
11 matches
Mail list logo