Re: [PATCH 3/3] make kthread_stop() scalable

2007-04-14 Thread Oleg Nesterov
On 04/14, Eric W. Biederman wrote: > > This is where I was going beyond what you were doing. I needed a flag to say > that this a kthread that is stopping to test in recalc_sigpending. To be > certain > of terminating interruptible sleeps. I could not get at your struct kthread > in that case.

Re: [PATCH 3/3] make kthread_stop() scalable

2007-04-14 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > On 04/13, Eric W. Biederman wrote: >> >> Oleg Nesterov <[EMAIL PROTECTED]> writes: >> >> > It's a shame kthread_stop() (may take a while!) runs with a global >> > semaphore >> > held. With this patch kthread() allocates all neccesary data (struct > kth

Re: [PATCH 3/3] make kthread_stop() scalable

2007-04-14 Thread Oleg Nesterov
On 04/13, Eric W. Biederman wrote: > > Oleg Nesterov <[EMAIL PROTECTED]> writes: > > > It's a shame kthread_stop() (may take a while!) runs with a global semaphore > > held. With this patch kthread() allocates all neccesary data (struct > > kthread) > > on its own stack, globals kthread_stop_xxx

Re: [PATCH 3/3] make kthread_stop() scalable

2007-04-13 Thread Eric W. Biederman
Oleg Nesterov <[EMAIL PROTECTED]> writes: > It's a shame kthread_stop() (may take a while!) runs with a global semaphore > held. With this patch kthread() allocates all neccesary data (struct kthread) > on its own stack, globals kthread_stop_xxx are deleted. Oleg so fare you patches have been in

[PATCH 3/3] make kthread_stop() scalable

2007-04-13 Thread Oleg Nesterov
It's a shame kthread_stop() (may take a while!) runs with a global semaphore held. With this patch kthread() allocates all neccesary data (struct kthread) on its own stack, globals kthread_stop_xxx are deleted. HACKS: - re-use task_struct->set_child_tid to point to "struct kthread"