Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-20 Thread Ulf Hansson
nd ; Adrian Hunter > > ; Rajan Vaja ; Jolly Shah > > ; Nava kishore Manne ; Olof > > Johansson ; linux-...@vger.kernel.org; DTML > > ; Linux Kernel Mailing List > ker...@vger.kernel.org>; Linux ARM > > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for Zynq

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-20 Thread Manish Narani
x-...@vger.kernel.org; DTML > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux ARM > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP > Platform Tap Delays Setup > > On Tue, 18 Jun 2019 at 06:59, Manish Narani wrote: > > > > Hi Uffe, >

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-20 Thread Manish Narani
x-...@vger.kernel.org; DTML > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux ARM > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP > Platform Tap Delays Setup > > On Wed, 19 Jun 2019 at 10:40, Manish Narani wrote: > > > > Hi Uffe, > &g

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-19 Thread Ulf Hansson
anish Narani ; Rob Herring > > ; Mark Rutland ; Adrian > > Hunter ; Rajan Vaja ; Jolly > > Shah ; Nava kishore Manne ; Olof > > Johansson ; linux-...@vger.kernel.org; DTML > > ; Linux Kernel Mailing List > ker...@vger.kernel.org>; Linux ARM > > Subject: Re:

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-19 Thread Ulf Hansson
On Wed, 19 Jun 2019 at 10:40, Manish Narani wrote: > > Hi Uffe, > > > > -Original Message- > > From: Ulf Hansson > > Sent: Monday, June 17, 2019 5:51 PM > [...] > > > > The "const struct zynqmp_eemi_ops *eemi_ops; should then be moved into > > a clock provider specific struct, which is as

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-19 Thread Manish Narani
Hi Uffe, > -Original Message- > From: Ulf Hansson > Sent: Monday, June 17, 2019 5:51 PM [...] > > The "const struct zynqmp_eemi_ops *eemi_ops; should then be moved into > a clock provider specific struct, which is assigned when calling > sdhci_arasan_register_sdclk. I understand that al

RE: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Manish Narani
ava kishore Manne ; Olof > Johansson ; linux-...@vger.kernel.org; DTML > ; Linux Kernel Mailing List ker...@vger.kernel.org>; Linux ARM > Subject: Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP > Platform Tap Delays Setup > > [...] > > > >> >

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Ulf Hansson
[...] > >> > >> > >>> In regards to the mmc data part, I suggest to drop the > >>> ->set_tap_delay() callback, but rather use a boolean flag to indicate > >>> whether clock phases needs to be changed for the variant. Potentially > >>> that could even be skipped and instead call clk_set_phase() > >

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Michal Simek
On 17. 06. 19 14:21, Ulf Hansson wrote: > On Mon, 17 Jun 2019 at 13:28, Michal Simek wrote: >> >> Hi, >> >> On 17. 06. 19 13:15, Ulf Hansson wrote: >>> On Tue, 11 Jun 2019 at 11:57, Manish Narani >>> wrote: Apart from taps set by auto tuning, ZynqMP platform has feature to set the

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Ulf Hansson
On Mon, 17 Jun 2019 at 13:28, Michal Simek wrote: > > Hi, > > On 17. 06. 19 13:15, Ulf Hansson wrote: > > On Tue, 11 Jun 2019 at 11:57, Manish Narani > > wrote: > >> > >> Apart from taps set by auto tuning, ZynqMP platform has feature to set > >> the tap values manually. Add support to read tap

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Michal Simek
Hi, On 17. 06. 19 13:15, Ulf Hansson wrote: > On Tue, 11 Jun 2019 at 11:57, Manish Narani wrote: >> >> Apart from taps set by auto tuning, ZynqMP platform has feature to set >> the tap values manually. Add support to read tap delay values from >> DT and set the same in HW via ZynqMP SoC framework

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-17 Thread Ulf Hansson
On Tue, 11 Jun 2019 at 11:57, Manish Narani wrote: > > Apart from taps set by auto tuning, ZynqMP platform has feature to set > the tap values manually. Add support to read tap delay values from > DT and set the same in HW via ZynqMP SoC framework. Reading Tap > Delays from DT is optional, if the

Re: [PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-13 Thread Adrian Hunter
On 11/06/19 12:56 PM, Manish Narani wrote: > Apart from taps set by auto tuning, ZynqMP platform has feature to set > the tap values manually. Add support to read tap delay values from > DT and set the same in HW via ZynqMP SoC framework. Reading Tap > Delays from DT is optional, if the property is

[PATCH 3/3] mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup

2019-06-11 Thread Manish Narani
Apart from taps set by auto tuning, ZynqMP platform has feature to set the tap values manually. Add support to read tap delay values from DT and set the same in HW via ZynqMP SoC framework. Reading Tap Delays from DT is optional, if the property is not available in DT the driver will use the pre-de