Re: [PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-24 Thread Shawn Guo
On Thu, Oct 24, 2013 at 09:58:53PM +0200, Rostislav Lisovy wrote: > I saw that most of the vendor prefixes are somehow shortened (e.g. > Freescale -- fsl, etc.). The 'fsl' is the stock symbol of Freescale. If that's not the case for voipac, I think 'voipac' is more appropriate. Shawn > On Thu,

Re: [PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-24 Thread Rostislav Lisovy
I saw that most of the vendor prefixes are somehow shortened (e.g. Freescale -- fsl, etc.). Rostislav Lisovy On Thu, 2013-10-24 at 14:49 -0500, Matt Sealey wrote: > On Thu, Oct 24, 2013 at 2:12 PM, Rostislav Lisovy wrote: > > Dear Shawn; > > Thank you for your comments. > > Should I also add V

Re: [PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-24 Thread Matt Sealey
On Thu, Oct 24, 2013 at 2:12 PM, Rostislav Lisovy wrote: > Dear Shawn; > Thank you for your comments. > Should I also add Voipac to > Documentation/devicetree/bindings/vendor-prefixes.txt? I would agree with that, but why is your chosen prefix "vp" instead of "voipac" anyway? -- Matt Sealey --

Re: [PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-24 Thread Rostislav Lisovy
Dear Shawn; Thank you for your comments. Should I also add Voipac to Documentation/devicetree/bindings/vendor-prefixes.txt? Best regards; Rostislav Lisovy On Wed, 2013-10-23 at 15:27 +0800, Shawn Guo wrote: > On Tue, Oct 22, 2013 at 07:07:22PM +0200, Rostislav Lisovy wrote: > > Enable UART1 and

Re: [PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-23 Thread Shawn Guo
On Tue, Oct 22, 2013 at 07:07:22PM +0200, Rostislav Lisovy wrote: > Enable UART1 and FEC You have more than these two enabled. > > Signed-off-by: Rostislav Lisovy > > create mode 100644 arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi > > diff --git a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi

[PATCH 3/4] ARM: dts: i.MX53: dts for Voipac x53-dmm-668 module

2013-10-22 Thread Rostislav Lisovy
Enable UART1 and FEC Signed-off-by: Rostislav Lisovy create mode 100644 arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi diff --git a/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi b/arch/arm/boot/dts/imx53-voipac-dmm-668.dtsi new file mode 100644 index 000..04695c9 --- /dev/null +++ b/arch/arm/b