Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 16:26 -0500, Rob Herring wrote: > On Wed, Jun 14, 2017 at 01:56:48PM -0700, Joe Perches wrote: > > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > > From: Pantelis Antoniou [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > >

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 16:26 -0500, Rob Herring wrote: > On Wed, Jun 14, 2017 at 01:56:48PM -0700, Joe Perches wrote: > > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > > From: Pantelis Antoniou [] > > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > > > [] > > > @@ -1470,6 +1471,123 @@

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Rob Herring
On Wed, Jun 14, 2017 at 01:56:48PM -0700, Joe Perches wrote: > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > From: Pantelis Antoniou > > I think the commit subject is wrong. > It adds an "of" specific bit to vsprintf.c. > The subject should be >

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Rob Herring
On Wed, Jun 14, 2017 at 01:56:48PM -0700, Joe Perches wrote: > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > From: Pantelis Antoniou > > I think the commit subject is wrong. > It adds an "of" specific bit to vsprintf.c. > The subject should be > 'vsprintf:  Add %p extension "%pO" for

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 07:30 -0500, Rob Herring wrote: > On Wed, Jun 14, 2017 at 3:56 PM, Joe Perches wrote: > > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > > From: Pantelis Antoniou > > > > I think the commit subject is wrong. > >

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Joe Perches
On Thu, 2017-06-15 at 07:30 -0500, Rob Herring wrote: > On Wed, Jun 14, 2017 at 3:56 PM, Joe Perches wrote: > > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > > > From: Pantelis Antoniou > > > > I think the commit subject is wrong. > > It adds an "of" specific bit to vsprintf.c. > >

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Rob Herring
On Wed, Jun 14, 2017 at 3:56 PM, Joe Perches wrote: > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: >> From: Pantelis Antoniou > > I think the commit subject is wrong. > It adds an "of" specific bit to vsprintf.c. > The subject should be

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-15 Thread Rob Herring
On Wed, Jun 14, 2017 at 3:56 PM, Joe Perches wrote: > On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: >> From: Pantelis Antoniou > > I think the commit subject is wrong. > It adds an "of" specific bit to vsprintf.c. > The subject should be > 'vsprintf: Add %p extension "%pO" for device

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-14 Thread Joe Perches
On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > From: Pantelis Antoniou I think the commit subject is wrong. It adds an "of" specific bit to vsprintf.c. The subject should be 'vsprintf:  Add %p extension "%pO" for device tree' > 90% of the usage of device

Re: [PATCH 3/4] of: Custom printk format specifier for device node

2017-06-14 Thread Joe Perches
On Wed, 2017-06-14 at 15:30 -0500, Rob Herring wrote: > From: Pantelis Antoniou I think the commit subject is wrong. It adds an "of" specific bit to vsprintf.c. The subject should be 'vsprintf:  Add %p extension "%pO" for device tree' > 90% of the usage of device node's full_name is printing it

[PATCH 3/4] of: Custom printk format specifier for device node

2017-06-14 Thread Rob Herring
From: Pantelis Antoniou 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For

[PATCH 3/4] of: Custom printk format specifier for device node

2017-06-14 Thread Rob Herring
From: Pantelis Antoniou 90% of the usage of device node's full_name is printing it out in a kernel message. Preparing for the eventual delayed allocation introduce a custom printk format specifier that is both more compact and more pleasant to the eye. For instance typical use is: