Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > On Tue, 18 Dec 2007, Erez Zadok wrote: > > In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > > > In order to fix unionfs truncation, we need to move the lower > > > notify_change > > > out of the loop in unionfs_setattr. But when I came

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Hugh Dickins
On Tue, 18 Dec 2007, Erez Zadok wrote: > In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > > In order to fix unionfs truncation, we need to move the lower notify_change > > out of the loop in unionfs_setattr. But when I came to do that, I couldn't > [...] > > Hugh, I want to understand how

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Hugh Dickins writes: > In order to fix unionfs truncation, we need to move the lower notify_change > out of the loop in unionfs_setattr. But when I came to do that, I couldn't [...] Hugh, I want to understand how patches 3/4 and 4/4 are related. In patch 3 you

[PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Hugh Dickins
In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I couldn't understand that loop at all: its continues and breaks and gotos are obscure, most particularly the "if (copyup || (bindex != bstart)) continue;"

[PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Hugh Dickins
In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I couldn't understand that loop at all: its continues and breaks and gotos are obscure, most particularly the if (copyup || (bindex != bstart)) continue;

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Erez Zadok
In message [EMAIL PROTECTED], Hugh Dickins writes: In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I couldn't [...] Hugh, I want to understand how patches 3/4 and 4/4 are related. In patch 3 you say in

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Hugh Dickins
On Tue, 18 Dec 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I couldn't [...] Hugh, I want to understand how patches

Re: [PATCH 3/4] unionfs: restructure unionfs_setattr

2007-12-18 Thread Erez Zadok
In message [EMAIL PROTECTED], Hugh Dickins writes: On Tue, 18 Dec 2007, Erez Zadok wrote: In message [EMAIL PROTECTED], Hugh Dickins writes: In order to fix unionfs truncation, we need to move the lower notify_change out of the loop in unionfs_setattr. But when I came to do that, I