Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:29:31 +0100, Sebastian Hesselbarth wrote : > >>Hmm, you probably know better than me, but if cpuclk == cpupll > >>is always true we don't need another clk layer here. If you > >>can scale down cpuclk from cpupll and we just have no driver > >>for it, I am fine with it. > >> > >

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 01:17 PM, Alexandre Belloni wrote: On 21/03/2014 at 13:11:29 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: Alexandre, Thanks for starting this! I'll start with the most obvious things first and have a closer look on it later. I will

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:11:29 +0100, Sebastian Hesselbarth wrote : > On 03/21/2014 12:43 PM, Alexandre Belloni wrote: > > Alexandre, > > Thanks for starting this! I'll start with the most obvious > things first and have a closer look on it later. > I will rework and wait for your other comments

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: Alexandre, Thanks for starting this! I'll start with the most obvious things first and have a closer look on it later. Missing commit description here. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/berlin2q.dtsi | 20

[PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/berlin2q.dtsi | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index 07452a7483fa..19d2c82b0664 100644 ---

[PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- arch/arm/boot/dts/berlin2q.dtsi | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi index 07452a7483fa..19d2c82b0664

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: Alexandre, Thanks for starting this! I'll start with the most obvious things first and have a closer look on it later. Missing commit description here. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com ---

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:11:29 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: Alexandre, Thanks for starting this! I'll start with the most obvious things first and have a closer look on it later. I will rework and wait for your other comments before

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Sebastian Hesselbarth
On 03/21/2014 01:17 PM, Alexandre Belloni wrote: On 21/03/2014 at 13:11:29 +0100, Sebastian Hesselbarth wrote : On 03/21/2014 12:43 PM, Alexandre Belloni wrote: Alexandre, Thanks for starting this! I'll start with the most obvious things first and have a closer look on it later. I will

Re: [PATCH 3/5] ARM: berlin/dt: add cpupll and syspll support to BG2Q

2014-03-21 Thread Alexandre Belloni
On 21/03/2014 at 13:29:31 +0100, Sebastian Hesselbarth wrote : Hmm, you probably know better than me, but if cpuclk == cpupll is always true we don't need another clk layer here. If you can scale down cpuclk from cpupll and we just have no driver for it, I am fine with it. You can