Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Ingo Molnar
* Andi Kleen wrote: > On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote: > > On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven > > wrote: > > > > > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > > > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Andi Kleen
On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote: > On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven > wrote: > > > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > > > need to include

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Andrew Morton
On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven wrote: > On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > > need to include linux/sched.h > > Really? is the worst choice w.r.t. include hell. Yes.

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Andrew Morton
On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven ge...@linux-m68k.org wrote: On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen a...@firstfloor.org wrote: might_sleep is moving from linux/kernel.h to linux/sched.h, so any users need to include linux/sched.h Really? linux/sched.h is the

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Andi Kleen
On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote: On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven ge...@linux-m68k.org wrote: On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen a...@firstfloor.org wrote: might_sleep is moving from linux/kernel.h to linux/sched.h, so any

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-09-10 Thread Ingo Molnar
* Andi Kleen a...@firstfloor.org wrote: On Tue, Sep 10, 2013 at 04:52:12PM -0700, Andrew Morton wrote: On Sat, 31 Aug 2013 20:22:23 +0200 Geert Uytterhoeven ge...@linux-m68k.org wrote: On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen a...@firstfloor.org wrote: might_sleep is moving

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-08-31 Thread Geert Uytterhoeven
On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen wrote: > might_sleep is moving from linux/kernel.h to linux/sched.h, so any users > need to include linux/sched.h Really? is the worst choice w.r.t. include hell. > This was done with a mechanistic script and some uses may be redundant > (already

Re: [PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-08-31 Thread Geert Uytterhoeven
On Fri, Aug 16, 2013 at 11:17 PM, Andi Kleen a...@firstfloor.org wrote: might_sleep is moving from linux/kernel.h to linux/sched.h, so any users need to include linux/sched.h Really? linux/sched.h is the worst choice w.r.t. include hell. This was done with a mechanistic script and some uses

[PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-08-16 Thread Andi Kleen
From: Andi Kleen might_sleep is moving from linux/kernel.h to linux/sched.h, so any users need to include linux/sched.h This was done with a mechanistic script and some uses may be redundant (already included in some other include file). However it's good practice to always include any needed

[PATCH 3/6] tree-sweep: Include linux/sched.h for might_sleep users

2013-08-16 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com might_sleep is moving from linux/kernel.h to linux/sched.h, so any users need to include linux/sched.h This was done with a mechanistic script and some uses may be redundant (already included in some other include file). However it's good practice to always