[PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-19 Thread Fengguang Wu
Miklos Szeredi <[EMAIL PROTECTED]> and me identified a writeback bug: > The following strange behavior can be observed: > > 1. large file is written > 2. after 30 seconds, nr_dirty goes down by 1024 > 3. then for some time (< 30 sec) nothing happens (disk idle) > 4. then nr_dirty again goes down

[PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-19 Thread Fengguang Wu
Miklos Szeredi [EMAIL PROTECTED] and me identified a writeback bug: The following strange behavior can be observed: 1. large file is written 2. after 30 seconds, nr_dirty goes down by 1024 3. then for some time ( 30 sec) nothing happens (disk idle) 4. then nr_dirty again goes down by 1024

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-17 Thread Fengguang Wu
On Mon, Aug 13, 2007 at 06:30:00PM +0800, Fengguang Wu wrote: > > On Sun, Aug 12, 2007 at 05:11:23PM +0800, Fengguang Wu wrote: > > > Miklos Szeredi <[EMAIL PROTECTED]> and me identified a writeback bug: > > > Basicly they are > > > - during the dd: ~16M > > > - after 30s: ~4M > > > - after

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-17 Thread Fengguang Wu
On Mon, Aug 13, 2007 at 06:30:00PM +0800, Fengguang Wu wrote: On Sun, Aug 12, 2007 at 05:11:23PM +0800, Fengguang Wu wrote: Miklos Szeredi [EMAIL PROTECTED] and me identified a writeback bug: Basicly they are - during the dd: ~16M - after 30s: ~4M - after 5s: ~4M -

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-13 Thread Fengguang Wu
On Mon, Aug 13, 2007 at 11:03:21AM +1000, David Chinner wrote: > > --- linux-2.6.23-rc2-mm2.orig/fs/buffer.c > > +++ linux-2.6.23-rc2-mm2/fs/buffer.c > > @@ -1713,7 +1713,6 @@ done: > > * The page and buffer_heads can be released at any time from > > * here on. > >

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-13 Thread Fengguang Wu
On Mon, Aug 13, 2007 at 11:03:21AM +1000, David Chinner wrote: --- linux-2.6.23-rc2-mm2.orig/fs/buffer.c +++ linux-2.6.23-rc2-mm2/fs/buffer.c @@ -1713,7 +1713,6 @@ done: * The page and buffer_heads can be released at any time from * here on. */

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-12 Thread David Chinner
On Sun, Aug 12, 2007 at 05:11:23PM +0800, Fengguang Wu wrote: > Miklos Szeredi <[EMAIL PROTECTED]> and me identified a writeback bug: > Basicly they are > - during the dd: ~16M > - after 30s: ~4M > - after 5s: ~4M > - after 5s: ~176M > > The box has 2G memory. > > Question 1: >

[PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-12 Thread Fengguang Wu
Miklos Szeredi <[EMAIL PROTECTED]> and me identified a writeback bug: > The following strange behavior can be observed: > > 1. large file is written > 2. after 30 seconds, nr_dirty goes down by 1024 > 3. then for some time (< 30 sec) nothing happens (disk idle) > 4. then nr_dirty again goes down

[PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-12 Thread Fengguang Wu
Miklos Szeredi [EMAIL PROTECTED] and me identified a writeback bug: The following strange behavior can be observed: 1. large file is written 2. after 30 seconds, nr_dirty goes down by 1024 3. then for some time ( 30 sec) nothing happens (disk idle) 4. then nr_dirty again goes down by 1024

Re: [PATCH 3/6] writeback: remove pages_skipped accounting in __block_write_full_page()

2007-08-12 Thread David Chinner
On Sun, Aug 12, 2007 at 05:11:23PM +0800, Fengguang Wu wrote: Miklos Szeredi [EMAIL PROTECTED] and me identified a writeback bug: Basicly they are - during the dd: ~16M - after 30s: ~4M - after 5s: ~4M - after 5s: ~176M The box has 2G memory. Question 1: How come the