Re: [PATCH 3/7] lib/random32.c: Replace an #ifdef with a stub prandom_state_selftest()

2014-06-08 Thread George Spelvin
>> #ifdef CONFIG_RANDOM32_SELFTEST >> static void __init prandom_state_selftest(void); >> +#else >> +#define prandom_state_selftest() (void)0 > Fine by me. I think you can remove this '(void)0' here, though. That's the standard way to write a no-op statement in C. I seem to recall there's a

Re: [PATCH 3/7] lib/random32.c: Replace an #ifdef with a stub prandom_state_selftest()

2014-06-08 Thread Daniel Borkmann
On 06/07/2014 10:22 AM, George Spelvin wrote: The preferred Linux style for optional features is to define no-op stub functions rather than wrap each call site in #ifdef. Signed-off-by: George Spelvin --- lib/random32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH 3/7] lib/random32.c: Replace an #ifdef with a stub prandom_state_selftest()

2014-06-07 Thread George Spelvin
The preferred Linux style for optional features is to define no-op stub functions rather than wrap each call site in #ifdef. Signed-off-by: George Spelvin --- lib/random32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/random32.c b/lib/random32.c index 2e7c15c0..e8