Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-21 Thread Namhyung Kim
On Mon, Apr 20, 2015 at 04:44:11PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 20, 2015 at 10:00:46PM +0900, Namhyung Kim escreveu: > > +++ b/tools/perf/ui/browsers/hists.c > > @@ -61,7 +61,7 @@ static int hist_browser__get_folding(struct hist_browser > > *browser) > >

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-21 Thread Namhyung Kim
On Mon, Apr 20, 2015 at 04:44:11PM -0300, Arnaldo Carvalho de Melo wrote: Em Mon, Apr 20, 2015 at 10:00:46PM +0900, Namhyung Kim escreveu: +++ b/tools/perf/ui/browsers/hists.c @@ -61,7 +61,7 @@ static int hist_browser__get_folding(struct hist_browser *browser)

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 20, 2015 at 10:00:46PM +0900, Namhyung Kim escreveu: > +++ b/tools/perf/ui/browsers/hists.c > @@ -61,7 +61,7 @@ static int hist_browser__get_folding(struct hist_browser > *browser) > rb_entry(nd, struct hist_entry, rb_node); > if

[PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Namhyung Kim
Since perf diff only supports stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields into them. And include it as an union member. Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 52

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Namhyung Kim
Hi Jiri, On Mon, Apr 20, 2015 at 10:20:02AM +0200, Jiri Olsa wrote: > On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: > > Since perf diff only support stdio output, TUI fields are only accessed > > from perf report (or perf top). So add new struct hist_entry_tui and > > move those

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Jiri Olsa
On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: > Since perf diff only support stdio output, TUI fields are only accessed > from perf report (or perf top). So add new struct hist_entry_tui and > move those fields into them. And include it as an union member. > SNIP > > -

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Namhyung Kim
Hi Jiri, On Mon, Apr 20, 2015 at 10:20:02AM +0200, Jiri Olsa wrote: On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: Since perf diff only support stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields

[PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Namhyung Kim
Since perf diff only supports stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields into them. And include it as an union member. Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/ui/browsers/hists.c | 52

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Jiri Olsa
On Sun, Apr 19, 2015 at 01:04:11PM +0900, Namhyung Kim wrote: Since perf diff only support stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields into them. And include it as an union member. SNIP - /* XXX

Re: [PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-20 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 20, 2015 at 10:00:46PM +0900, Namhyung Kim escreveu: +++ b/tools/perf/ui/browsers/hists.c @@ -61,7 +61,7 @@ static int hist_browser__get_folding(struct hist_browser *browser) rb_entry(nd, struct hist_entry, rb_node); if (he-ms.unfolded) -

[PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-18 Thread Namhyung Kim
Since perf diff only support stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields into them. And include it as an union member. Signed-off-by: Namhyung Kim --- tools/perf/ui/browsers/hists.c | 52

[PATCH 3/7] perf tools: Move TUI-specific fields to struct hist_entry_tui

2015-04-18 Thread Namhyung Kim
Since perf diff only support stdio output, TUI fields are only accessed from perf report (or perf top). So add new struct hist_entry_tui and move those fields into them. And include it as an union member. Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/ui/browsers/hists.c | 52