Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-06 Thread Vikas Shivappa
On Wed, 6 May 2015, Peter Zijlstra wrote: On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: Will fix the whitespace issues (including before return) or other possible coding convention issues. It could be more of a common sense to have this in checkpatch rather that manually ha

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-06 Thread Vikas Shivappa
On Wed, 6 May 2015, Peter Zijlstra wrote: On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: On Sat, 2 May 2015, Peter Zijlstra wrote: There's CAT in your subject, make up your minds already on what you want to call this stuff. We dont have control over the names.It is clear

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-06 Thread Matt Fleming
On Wed, 2015-05-06 at 10:09 +0200, Peter Zijlstra wrote: > > But we're not implementing an umbrella right? We're implementing Cache > QoS Enforcement (CQE aka. CAT). > > Why confuse things with calling it random other names? > > From what I understand the whole RDT thing is the umbrella term for

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-06 Thread Peter Zijlstra
On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: > Will fix the whitespace issues (including before return) or other possible > coding convention issues. > > It could be more of a common sense to have this in checkpatch rather that > manually having to pointing out. If you want to h

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-06 Thread Peter Zijlstra
On Mon, May 04, 2015 at 10:30:15AM -0700, Vikas Shivappa wrote: > On Sat, 2 May 2015, Peter Zijlstra wrote: > > > > >There's CAT in your subject, make up your minds already on what you want > >to call this stuff. > > We dont have control over the names.It is clear from the patch 0/7 where its If

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-04 Thread Vikas Shivappa
On Sat, 2 May 2015, Peter Zijlstra wrote: There's CAT in your subject, make up your minds already on what you want to call this stuff. We dont have control over the names.It is clear from the patch 0/7 where its explained that RDT is the umbrella term and CAT is a part of it and this patc

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-02 Thread Peter Zijlstra
There's CAT in your subject, make up your minds already on what you want to call this stuff. On Fri, May 01, 2015 at 06:36:37PM -0700, Vikas Shivappa wrote: > +static void rdt_free_closid(unsigned int clos) > +{ > + superfluous whitespace > + lockdep_assert_held(&rdt_group_mutex); > + > +

[PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-05-01 Thread Vikas Shivappa
Add support for cache bit mask manipulation. The change adds a file cache_mask to the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. Update to the CBM is done by writing to the IA32_L3_MASK_n. The RDT cgroup follows cgroup hierarchy ,mkdir and adding tasks to the cgroup neve

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-04-12 Thread Vikas Shivappa
On Thu, 9 Apr 2015, Marcelo Tosatti wrote: On Thu, Mar 12, 2015 at 04:16:03PM -0700, Vikas Shivappa wrote: Add support for cache bit mask manipulation. The change adds a file to the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. The RDT cgroup follows cgroup hierarchy ,m

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-04-09 Thread Marcelo Tosatti
On Thu, Mar 12, 2015 at 04:16:03PM -0700, Vikas Shivappa wrote: > Add support for cache bit mask manipulation. The change adds a file to > the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. > > The RDT cgroup follows cgroup hierarchy ,mkdir and adding tasks to the > cgroup nev

[PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-03-12 Thread Vikas Shivappa
Add support for cache bit mask manipulation. The change adds a file to the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. The RDT cgroup follows cgroup hierarchy ,mkdir and adding tasks to the cgroup never fails. When a child cgroup is created it inherits the CLOSid and the C

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-27 Thread Vikas Shivappa
On Fri, 27 Feb 2015, Tejun Heo wrote: Hello, Vikas. On Fri, Feb 27, 2015 at 11:34:16AM -0800, Vikas Shivappa wrote: This cgroup subsystem would basically let the user partition one of the Platform shared resource , the LLC cache. This could be extended in future I suppose LLC means last le

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-27 Thread Tejun Heo
Hello, Vikas. On Fri, Feb 27, 2015 at 11:34:16AM -0800, Vikas Shivappa wrote: > This cgroup subsystem would basically let the user partition one of the > Platform shared resource , the LLC cache. This could be extended in future I suppose LLC means last level cache? It'd be great if you can spel

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-27 Thread Vikas Shivappa
Hello Tejun, On Fri, 27 Feb 2015, Tejun Heo wrote: Hello, On Tue, Feb 24, 2015 at 03:16:40PM -0800, Vikas Shivappa wrote: Add support for cache bit mask manipulation. The change adds a file to the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. The RDT cgroup follows cgr

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-27 Thread Tejun Heo
On Fri, Feb 27, 2015 at 07:12:22AM -0500, Tejun Heo wrote: > I feel a bit underwhelmed about this new controller and its interface. > It is evidently at a lot lower level and way more niche than what > other controllers are doing, even cpuset. At the same time, as long > as it's well isolated, it

Re: [PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-27 Thread Tejun Heo
Hello, On Tue, Feb 24, 2015 at 03:16:40PM -0800, Vikas Shivappa wrote: > Add support for cache bit mask manipulation. The change adds a file to > the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. > > The RDT cgroup follows cgroup hierarchy ,mkdir and adding tasks to the > cg

[PATCH 3/7] x86/intel_rdt: Support cache bit mask for Intel CAT

2015-02-24 Thread Vikas Shivappa
Add support for cache bit mask manipulation. The change adds a file to the RDT cgroup which represents the CBM(cache bit mask) for the cgroup. The RDT cgroup follows cgroup hierarchy ,mkdir and adding tasks to the cgroup never fails. When a child cgroup is created it inherits the CLOSid and the C