Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Daniel Thompson
On 12/09/14 18:23, Russell King - ARM Linux wrote: > On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: >> On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: >>> On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Russell King - ARM Linux
On Sun, Sep 14, 2014 at 07:36:31AM +0100, Daniel Thompson wrote: > > - if (!relinquish) > > + if (!relinquish) { > > + /* Restore default handler and registers */ > > + local_fiq_disable(); > > + set_fiq_regs(_fiq_regs); > > This variable was declared as

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Daniel Thompson
On 12/09/14 18:23, Russell King - ARM Linux wrote: > On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: >> On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: >>> On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Daniel Thompson
On 12/09/14 18:23, Russell King - ARM Linux wrote: On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Russell King - ARM Linux
On Sun, Sep 14, 2014 at 07:36:31AM +0100, Daniel Thompson wrote: - if (!relinquish) + if (!relinquish) { + /* Restore default handler and registers */ + local_fiq_disable(); + set_fiq_regs(dfl_fiq_regs); This variable was declared as def_fiq_regs .

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-14 Thread Daniel Thompson
On 12/09/14 18:23, Russell King - ARM Linux wrote: On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-13 Thread Daniel Thompson
On 12/09/14 18:14, Russell King - ARM Linux wrote: > On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: >> This patch introduces a new default FIQ handler that is structured in a >> similar way to the existing ARM exception handler and result in the FIQ >> being handled by C code

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-13 Thread Daniel Thompson
On 12/09/14 18:03, Russell King - ARM Linux wrote: > On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: >> -.macro svc_entry, stack_hole=0 >> +.macro svc_entry, stack_hole=0, call_trace=1 >> UNWIND(.fnstart) >> UNWIND(.save {r0 - pc} ) >>

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-13 Thread Daniel Thompson
On 12/09/14 18:03, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: -.macro svc_entry, stack_hole=0 +.macro svc_entry, stack_hole=0, call_trace=1 UNWIND(.fnstart) UNWIND(.save {r0 - pc} ) sub sp,

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-13 Thread Daniel Thompson
On 12/09/14 18:14, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new default FIQ handler that is structured in a similar way to the existing ARM exception handler and result in the FIQ being handled by C code running on

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: > On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: > > On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > > > This patch introduces a new default FIQ handler that is structured in a >

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: > On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > > This patch introduces a new default FIQ handler that is structured in a > > similar way to the existing ARM exception handler and result in the FIQ > >

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > This patch introduces a new default FIQ handler that is structured in a > similar way to the existing ARM exception handler and result in the FIQ > being handled by C code running on the SVC stack (despite this code run > in the

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
And another thing... On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > + .align 5 > +__fiq_abt: > + svc_entry 0, 0 Right, so this function is called __fiq_abt. ... > + svc_exit_via_fiq > + UNWIND(.fnend ) > +ENDPROC(__fiq_svc) Or is it called __fiq_svc

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:03:07PM +0100, Russell King - ARM Linux wrote: > On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > > - .macro svc_entry, stack_hole=0 > > + .macro svc_entry, stack_hole=0, call_trace=1 > > UNWIND(.fnstart ) > > UNWIND(.save {r0 - pc}

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: > - .macro svc_entry, stack_hole=0 > + .macro svc_entry, stack_hole=0, call_trace=1 > UNWIND(.fnstart ) > UNWIND(.save {r0 - pc} ) > sub sp, sp, #(S_FRAME_SIZE + \stack_hole - 4) > @@

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: - .macro svc_entry, stack_hole=0 + .macro svc_entry, stack_hole=0, call_trace=1 UNWIND(.fnstart ) UNWIND(.save {r0 - pc} ) sub sp, sp, #(S_FRAME_SIZE + \stack_hole - 4) @@ -183,7

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:03:07PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: - .macro svc_entry, stack_hole=0 + .macro svc_entry, stack_hole=0, call_trace=1 UNWIND(.fnstart ) UNWIND(.save {r0 - pc}

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
And another thing... On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: + .align 5 +__fiq_abt: + svc_entry 0, 0 Right, so this function is called __fiq_abt. ... + svc_exit_via_fiq + UNWIND(.fnend ) +ENDPROC(__fiq_svc) Or is it called __fiq_svc ? --

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new default FIQ handler that is structured in a similar way to the existing ARM exception handler and result in the FIQ being handled by C code running on the SVC stack (despite this code run in the FIQ

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new default FIQ handler that is structured in a similar way to the existing ARM exception handler and result in the FIQ being

Re: [PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-12 Thread Russell King - ARM Linux
On Fri, Sep 12, 2014 at 06:19:08PM +0100, Russell King - ARM Linux wrote: On Fri, Sep 12, 2014 at 06:14:04PM +0100, Russell King - ARM Linux wrote: On Thu, Sep 11, 2014 at 12:31:14PM +0100, Daniel Thompson wrote: This patch introduces a new default FIQ handler that is structured in a

[PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-11 Thread Daniel Thompson
This patch introduces a new default FIQ handler that is structured in a similar way to the existing ARM exception handler and result in the FIQ being handled by C code running on the SVC stack (despite this code run in the FIQ handler is subject to severe limitations with respect to locking making

[PATCH 3.17-rc4 v5 2/6] arm: fiq: Replace default FIQ handler

2014-09-11 Thread Daniel Thompson
This patch introduces a new default FIQ handler that is structured in a similar way to the existing ARM exception handler and result in the FIQ being handled by C code running on the SVC stack (despite this code run in the FIQ handler is subject to severe limitations with respect to locking making