Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-15 Thread Luis R. Rodriguez
On Wed, Jun 15, 2016 at 05:44:01PM +0200, Julia Lawall wrote: > > > On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > > OK thanks. I remove --very-quiet now if --profile is used within SPFLAGS, > > I'll extend > > this to also avoid --very-quiet if --show-trying is used. SPFLAGS is where > > you

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-15 Thread Julia Lawall
On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > On Wed, Jun 15, 2016 at 09:39:49AM +0200, Julia Lawall wrote: > > > > > > On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rod

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-15 Thread Luis R. Rodriguez
On Wed, Jun 15, 2016 at 09:39:49AM +0200, Julia Lawall wrote: > > > On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Tue, Jun 14, 2016 at 10:47:32PM +

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-15 Thread Julia Lawall
On Wed, 15 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rod

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 11:17:13PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Tue, Jun 14, 2016 at 07:22:03A

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Julia Lawall
On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 13 Jun 2016, Luis R

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 10:47:32PM +0200, Julia Lawall wrote: > > > On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > > > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Mon, Jun 13, 2016 at 09:50:15P

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Julia Lawall
On Tue, 14 Jun 2016, Luis R. Rodriguez wrote: > On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Mon, Jun 13, 2016 at 09:50:15PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Mon, 13 Jun 2016, Luis R

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-14 Thread Luis R. Rodriguez
On Tue, Jun 14, 2016 at 07:22:03AM +0200, Julia Lawall wrote: > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > On Mon, Jun 13, 2016 at 09:50:15PM +0200, Julia Lawall wrote: > > > > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > > I'll redirect stderr to stdout

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Julia Lawall
On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > On Mon, Jun 13, 2016 at 09:50:15PM +0200, Julia Lawall wrote: > > > > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Fri, Jun 10, 2016 at 11:21:28PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Fri, 10 Jun 2016, Luis R

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Julia Lawall
On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > On Mon, Jun 13, 2016 at 09:48:30PM +0200, Julia Lawall wrote: > > > > > > On Mon, 13 Jun 2016, Wolfram Sang wrote: > > > > > > > > > Is there another scripts/coccinelle/ file I can use to test against to > > > > demo > > > > against glimpse/id

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Luis R. Rodriguez
On Mon, Jun 13, 2016 at 09:50:15PM +0200, Julia Lawall wrote: > > > On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > > > On Fri, Jun 10, 2016 at 11:21:28PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > On Fri, Jun 10, 2016 at 11:02:38P

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Luis R. Rodriguez
On Mon, Jun 13, 2016 at 09:48:30PM +0200, Julia Lawall wrote: > > > On Mon, 13 Jun 2016, Wolfram Sang wrote: > > > > > > Is there another scripts/coccinelle/ file I can use to test against to > > > demo > > > against glimpse/idutils/gitgrep best? > > > > I'd think this one may be a candidate:

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Julia Lawall
On Mon, 13 Jun 2016, Wolfram Sang wrote: > > > Is there another scripts/coccinelle/ file I can use to test against to demo > > against glimpse/idutils/gitgrep best? > > I'd think this one may be a candidate: > > scripts/coccinelle/misc/irqf_oneshot.cocci > > Not too many, but quite some matc

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Julia Lawall
On Mon, 13 Jun 2016, Luis R. Rodriguez wrote: > On Fri, Jun 10, 2016 at 11:21:28PM +0200, Julia Lawall wrote: > > > > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > > > On Fri, Jun 10, 2016 at 11:02:38PM +0200, Julia Lawall wrote: > > > > > > > > > > > > On Fri, 10 Jun 2016, Luis R

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 11:21:28PM +0200, Julia Lawall wrote: > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > On Fri, Jun 10, 2016 at 11:02:38PM +0200, Julia Lawall wrote: > > > > > > > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > > > > > Enable indexing optimizations heu

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Wolfram Sang
> Is there another scripts/coccinelle/ file I can use to test against to demo > against glimpse/idutils/gitgrep best? I'd think this one may be a candidate: scripts/coccinelle/misc/irqf_oneshot.cocci Not too many, but quite some matches over the tree. signature.asc Description: PGP signature

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Luis R. Rodriguez
On Sat, Jun 11, 2016 at 07:24:51AM +0200, Julia Lawall wrote: > > > On Fri, 10 Jun 2016, Wolfram Sang wrote: > > > > AFAICT coccinelle does not have integration support for id-utils though. > > > > I used it just today ;) -- "--use-idutils ./ID" > > > > ID was generated with simple 'mkid -s'.

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-13 Thread Luis R. Rodriguez
On Sat, Jun 11, 2016 at 07:54:39AM +0200, Julia Lawall wrote: > > > On Sat, 11 Jun 2016, Wolfram Sang wrote: > > > > > > real16m11.692s > > > user127m50.388s > > > sys 0m2.168s > > > > That's better but not a magnitude, I wonder. > > I think that it is because the filtering that C

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Wolfram Sang
> works pretty well, and there are quite a lot of files (7514) that contain > kfree. Ah, kfree. That explains, I missed that info. signature.asc Description: PGP signature

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Sat, 11 Jun 2016, Wolfram Sang wrote: > > > It's not as efficient as glimpse because the query language is simpler. > > Interesting, what is missing compared to glimpse? Glimpse allows queries that are arbitrary formulas, up to a limited level of complexity, involving both && and ||. F

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Wolfram Sang
> It's not as efficient as glimpse because the query language is simpler. Interesting, what is missing compared to glimpse? > So more filtering has to be done at the ocaml level. But it's probably > fine in most cases. For me, it has two advantages over glimpse: a) it is in the debian pack

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread SF Markus Elfring
> in practice though this seems to not perform better than > regular grep however its expected to help with some use cases > so we use that if you have no other indexing options in place > available. Would you like to fix a typo in this paragraph? Regards, Markus

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Sat, 11 Jun 2016, Wolfram Sang wrote: > > > real16m11.692s > > user127m50.388s > > sys 0m2.168s > > That's better but not a magnitude, I wonder. I think that it is because the filtering that Coccinelle does already works pretty well, and there are quite a lot of files (7514) t

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Wolfram Sang
> real16m11.692s > user127m50.388s > sys 0m2.168s That's better but not a magnitude, I wonder. signature.asc Description: PGP signature

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Fri, 10 Jun 2016, Wolfram Sang wrote: > > AFAICT coccinelle does not have integration support for id-utils though. > > I used it just today ;) -- "--use-idutils ./ID" > > ID was generated with simple 'mkid -s'. Coccinelle includes a script scripts/idutils_index.sh This does mkid -i C --ou

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Sat, 11 Jun 2016, Luis R. Rodriguez wrote: > On Fri, Jun 10, 2016 at 11:51:26PM +0200, Wolfram Sang wrote: > > > AFAICT coccinelle does not have integration support for id-utils though. > > > > I used it just today ;) -- "--use-idutils ./ID" > > > > ID was generated with simple 'mkid -s'. >

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > On Fri, Jun 10, 2016 at 11:43:57PM +0200, Wolfram Sang wrote: > > > > Well, slightly better. > > > > > > No, it should be much better. You would have to look at the standard > > > > I use id-utils regularly and it is indeed at least a magnitude

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Luis R. Rodriguez
On Sat, Jun 11, 2016 at 12:08:32AM +0200, Luis R. Rodriguez wrote: > On Fri, Jun 10, 2016 at 11:51:26PM +0200, Wolfram Sang wrote: > > > AFAICT coccinelle does not have integration support for id-utils though. > > > > I used it just today ;) -- "--use-idutils ./ID" > > > > ID was generated with s

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 11:51:26PM +0200, Wolfram Sang wrote: > > AFAICT coccinelle does not have integration support for id-utils though. > > I used it just today ;) -- "--use-idutils ./ID" > > ID was generated with simple 'mkid -s'. > Sweet, testing that now. Luis

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Wolfram Sang
> AFAICT coccinelle does not have integration support for id-utils though. I used it just today ;) -- "--use-idutils ./ID" ID was generated with simple 'mkid -s'. signature.asc Description: PGP signature

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 11:43:57PM +0200, Wolfram Sang wrote: > > > Well, slightly better. > > > > No, it should be much better. You would have to look at the standard > > I use id-utils regularly and it is indeed at least a magnitude better. > The indexing often pays off already with the first

Re: [Cocci] [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Wolfram Sang
> > Well, slightly better. > > No, it should be much better. You would have to look at the standard I use id-utils regularly and it is indeed at least a magnitude better. The indexing often pays off already with the first coccinelle run for me. Highly recommended. signature.asc Description:

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > On Fri, Jun 10, 2016 at 11:02:38PM +0200, Julia Lawall wrote: > > > > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > > > Enable indexing optimizations heuristics. Coccinelle has > > > support to make use of its own enhanced "grep" mecha

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Luis R. Rodriguez
On Fri, Jun 10, 2016 at 11:02:38PM +0200, Julia Lawall wrote: > > > On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > > > Enable indexing optimizations heuristics. Coccinelle has > > support to make use of its own enhanced "grep" mechanisms > > instead of using regular grep for searching code 'coc

Re: [PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Julia Lawall
On Fri, 10 Jun 2016, Luis R. Rodriguez wrote: > Enable indexing optimizations heuristics. Coccinelle has > support to make use of its own enhanced "grep" mechanisms > instead of using regular grep for searching code 'coccigrep', > in practice though this seems to not perform better than > regula

[PATCH 4/4] coccicheck: add indexing enhancement options

2016-06-10 Thread Luis R. Rodriguez
Enable indexing optimizations heuristics. Coccinelle has support to make use of its own enhanced "grep" mechanisms instead of using regular grep for searching code 'coccigrep', in practice though this seems to not perform better than regular grep however its expected to help with some use cases so