Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2013-01-09 Thread Lee Jones
On Wed, 19 Dec 2012, Lee Jones wrote: > Some platforms provide clocks which require enabling before the > SMSC911x chip will power on. This patch uses the new common clk > framework to do just that. If no clock is provided, it will just > be ignored and the driver will continue to assume that no c

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-21 Thread Russell King - ARM Linux
On Fri, Dec 21, 2012 at 09:13:06AM +, Lee Jones wrote: > Are you saying remove "pdata->clk = NULL;" and test for IS_ERR > every time? Exactly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-21 Thread Lee Jones
On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 08:35:14PM +, Lee Jones wrote: > > On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > > > > > On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > > > > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones w

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 08:35:14PM +, Lee Jones wrote: > On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > > > On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > > > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones wrote: > > > > > > > Some platforms provide clocks which require

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-20 Thread Lee Jones
On Thu, 20 Dec 2012, Russell King - ARM Linux wrote: > On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones wrote: > > > > > Some platforms provide clocks which require enabling before the > > > SMSC911x chip will power on. This patch uses

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-20 Thread Russell King - ARM Linux
On Thu, Dec 20, 2012 at 08:12:08PM +0100, Linus Walleij wrote: > On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones wrote: > > > Some platforms provide clocks which require enabling before the > > SMSC911x chip will power on. This patch uses the new common clk > > framework to do just that. If no clock i

Re: [PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-20 Thread Linus Walleij
On Wed, Dec 19, 2012 at 6:19 PM, Lee Jones wrote: > Some platforms provide clocks which require enabling before the > SMSC911x chip will power on. This patch uses the new common clk > framework to do just that. If no clock is provided, it will just > be ignored and the driver will continue to ass

[PATCH 4/4] net/smsc911x: Provide common clock functionality

2012-12-19 Thread Lee Jones
Some platforms provide clocks which require enabling before the SMSC911x chip will power on. This patch uses the new common clk framework to do just that. If no clock is provided, it will just be ignored and the driver will continue to assume that no clock is required for the chip to run successful