Re: [PATCH 4/5] pinctrl: rockchip: add missing of_node_put

2015-12-22 Thread Linus Walleij
On Mon, Dec 21, 2015 at 5:39 PM, Julia Lawall wrote: > for_each_child_of_node performs an of_node_get on each iteration, so a > return from the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle.lip6.fr): Patch

Re: [PATCH 4/5] pinctrl: rockchip: add missing of_node_put

2015-12-21 Thread Heiko Stübner
Hi Julia, Am Montag, 21. Dezember 2015, 17:39:47 schrieb Julia Lawall: > for_each_child_of_node performs an of_node_get on each iteration, so a > return from the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows (http://coccinelle

[PATCH 4/5] pinctrl: rockchip: add missing of_node_put

2015-12-21 Thread Julia Lawall
for_each_child_of_node performs an of_node_get on each iteration, so a return from the loop requires an of_node_put. A simplified version of the semantic patch that fixes this problem is as follows (http://coccinelle.lip6.fr): // @@ local idexpression n; expression e,e1; @@ for_each_child_of_n