Re: [PATCH 4/6] cpufreq: Use has_target() instead of !setpolicy

2019-06-19 Thread Viresh Kumar
On 19-06-19, 14:28, Rafael J. Wysocki wrote: > On Wed, Jun 19, 2019 at 1:36 PM Viresh Kumar wrote: > > > > For code consistency, use has_target() instead of !setpolicy everywhere, > > as it is already done at several places. > > That's OK > > > Maybe we should also use !has_target() for setpolic

Re: [PATCH 4/6] cpufreq: Use has_target() instead of !setpolicy

2019-06-19 Thread Rafael J. Wysocki
On Wed, Jun 19, 2019 at 1:36 PM Viresh Kumar wrote: > > For code consistency, use has_target() instead of !setpolicy everywhere, > as it is already done at several places. That's OK > Maybe we should also use !has_target() for setpolicy case to use only one > expression > for this differentiati

[PATCH 4/6] cpufreq: Use has_target() instead of !setpolicy

2019-06-19 Thread Viresh Kumar
For code consistency, use has_target() instead of !setpolicy everywhere, as it is already done at several places. Maybe we should also use !has_target() for setpolicy case to use only one expression for this differentiation. Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 6 +++--- 1