Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Dong Aisheng
On Fri, Aug 24, 2012 at 01:56:58AM +0800, Stephen Warren wrote: > On 08/23/2012 12:12 AM, Richard Zhao wrote: > > On Wed, Aug 22, 2012 at 11:21:03PM -0600, Stephen Warren wrote: > >> On 08/22/2012 01:18 AM, Dong Aisheng wrote: > >>> Signed-off-by: Dong Aisheng > >> > >>> diff --git a/drivers/regul

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Dong Aisheng
On Thu, Aug 23, 2012 at 07:17:41PM +0800, Mark Brown wrote: > On Thu, Aug 23, 2012 at 03:15:04PM +0800, Dong Aisheng wrote: > > On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote: > > > > With the conversion to regmap it'd also be good to convert the driver to > > > use the regmap helper f

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Stephen Warren
On 08/23/2012 12:12 AM, Richard Zhao wrote: > On Wed, Aug 22, 2012 at 11:21:03PM -0600, Stephen Warren wrote: >> On 08/22/2012 01:18 AM, Dong Aisheng wrote: >>> Signed-off-by: Dong Aisheng >> >>> diff --git a/drivers/regulator/anatop-regulator.c >>> b/drivers/regulator/anatop-regulator.c >> >>> @

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Mark Brown
On Thu, Aug 23, 2012 at 03:15:04PM +0800, Dong Aisheng wrote: > On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote: > > With the conversion to regmap it'd also be good to convert the driver to > > use the regmap helper functions for enable and voltage operations if > > possible. > The ana

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Dong Aisheng
On Thu, Aug 23, 2012 at 01:21:03PM +0800, Stephen Warren wrote: > On 08/22/2012 01:18 AM, Dong Aisheng wrote: > > Signed-off-by: Dong Aisheng > > > diff --git a/drivers/regulator/anatop-regulator.c > > b/drivers/regulator/anatop-regulator.c > > > @@ -109,7 +110,11 @@ static int __devinit anatop

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-23 Thread Dong Aisheng
On Wed, Aug 22, 2012 at 11:59:53PM +0800, Mark Brown wrote: > On Wed, Aug 22, 2012 at 03:18:45PM +0800, Dong Aisheng wrote: > > From: Dong Aisheng > > > > Using standard imx syscon API to access anatop register. > > Acked-by: Mark Brown > Thanks > With the conversion to regmap it'd also be go

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-22 Thread Richard Zhao
On Wed, Aug 22, 2012 at 11:21:03PM -0600, Stephen Warren wrote: > On 08/22/2012 01:18 AM, Dong Aisheng wrote: > > Signed-off-by: Dong Aisheng > > > diff --git a/drivers/regulator/anatop-regulator.c > > b/drivers/regulator/anatop-regulator.c > > > @@ -109,7 +110,11 @@ static int __devinit anatop

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-22 Thread Stephen Warren
On 08/22/2012 01:18 AM, Dong Aisheng wrote: > Signed-off-by: Dong Aisheng > diff --git a/drivers/regulator/anatop-regulator.c > b/drivers/regulator/anatop-regulator.c > @@ -109,7 +110,11 @@ static int __devinit anatop_regulator_probe(struct > platform_device *pdev) > rdesc->ops = &anatop

Re: [PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-22 Thread Mark Brown
On Wed, Aug 22, 2012 at 03:18:45PM +0800, Dong Aisheng wrote: > From: Dong Aisheng > > Using standard imx syscon API to access anatop register. Acked-by: Mark Brown With the conversion to regmap it'd also be good to convert the driver to use the regmap helper functions for enable and voltage o

[PATCH 4/7] regulator: anatop-regulator: convert to use imx-syscon to access anatop register

2012-08-22 Thread Dong Aisheng
From: Dong Aisheng Using standard imx syscon API to access anatop register. Signed-off-by: Dong Aisheng --- arch/arm/boot/dts/imx6q.dtsi |6 ++ drivers/regulator/Kconfig|2 +- drivers/regulator/anatop-regulator.c | 17 +++-- 3 files changed, 18 ins